Legacy Promotions: Add inverse_of/dependent options

Author: mamhoff

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-06-06 06:59:49 UTC using RuboCop version 1.76.0.
+# on 2025-06-06 10:38:29 UTC using RuboCop version 1.76.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,7 +14,7 @@ Gemspec/OrderedDependencies:
   Exclude:
     - 'core/solidus_core.gemspec'
 
-# Offense count: 175
+# Offense count: 179
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: with_first_argument, with_fixed_indentation
@@ -337,7 +337,7 @@ Rails/FilePath:
     - 'core/lib/spree/testing_support/dummy_app.rb'
     - 'sample/lib/spree/sample.rb'
 
-# Offense count: 61
+# Offense count: 57
 # Configuration parameters: Include.
 # Include: **/app/models/**/*.rb
 Rails/HasManyOrHasOneDependent:
@@ -379,7 +379,7 @@ Rails/IndexWith:
     - 'core/lib/spree/core/search/variant.rb'
     - 'core/lib/spree/preferences/preferable.rb'
 
-# Offense count: 35
+# Offense count: 30
 # Configuration parameters: IgnoreScopes, Include.
 # Include: **/app/models/**/*.rb
 Rails/InverseOf:

legacy_promotions/app/models/spree/promotion/actions/create_adjustment.rb

@@ -7,7 +7,7 @@ class CreateAdjustment < PromotionAction
         include Spree::CalculatedAdjustments
         include Spree::AdjustmentSource
 
-        has_many :adjustments, as: :source
+        has_many :adjustments, as: :source, dependent: :restrict_with_error
 
         delegate :eligible?, to: :promotion
 

legacy_promotions/app/models/spree/promotion/actions/create_item_adjustments.rb

@@ -7,7 +7,7 @@ class CreateItemAdjustments < PromotionAction
         include Spree::CalculatedAdjustments
         include Spree::AdjustmentSource
 
-        has_many :adjustments, as: :source
+        has_many :adjustments, as: :source, dependent: :restrict_with_error
 
         delegate :eligible?, to: :promotion
 

legacy_promotions/app/models/spree/promotion/actions/create_quantity_adjustments.rb

@@ -6,7 +6,7 @@ module Actions
       class CreateQuantityAdjustments < CreateItemAdjustments
         preference :group_size, :integer, default: 1
 
-        has_many :line_item_actions, foreign_key: :action_id, dependent: :destroy
+        has_many :line_item_actions, foreign_key: :action_id, dependent: :destroy, inverse_of: :action
         has_many :line_items, through: :line_item_actions
 
         ##

legacy_promotions/app/models/spree/promotion/rules/product.rb

@@ -8,8 +8,11 @@ module Rules
       # either come from assigned product group or are assingned directly to
       # the rule.
       class Product < PromotionRule
-        has_many :product_promotion_rules, dependent: :destroy, foreign_key: :promotion_rule_id,
-                                           class_name: 'Spree::ProductPromotionRule'
+        has_many :product_promotion_rules,
+          dependent: :destroy,
+          foreign_key: :promotion_rule_id,
+          class_name: 'Spree::ProductPromotionRule',
+          inverse_of: :promotion_rule
         has_many :products, class_name: 'Spree::Product', through: :product_promotion_rules
 
         def preload_relations

legacy_promotions/app/models/spree/promotion/rules/store.rb

@@ -4,9 +4,11 @@ module Spree
   class Promotion
     module Rules
       class Store < PromotionRule
-        has_many :promotion_rule_stores, class_name: "Spree::PromotionRuleStore",
-                                         foreign_key: :promotion_rule_id,
-                                         dependent: :destroy
+        has_many :promotion_rule_stores,
+          class_name: "Spree::PromotionRuleStore",
+          foreign_key: :promotion_rule_id,
+          dependent: :destroy,
+          inverse_of: :promotion_rule
         has_many :stores, through: :promotion_rule_stores, class_name: "Spree::Store"
 
         def preload_relations

legacy_promotions/app/models/spree/promotion/rules/taxon.rb

@@ -4,8 +4,11 @@ module Spree
   class Promotion < Spree::Base
     module Rules
       class Taxon < PromotionRule
-        has_many :promotion_rule_taxons, class_name: 'Spree::PromotionRuleTaxon', foreign_key: :promotion_rule_id,
-          dependent: :destroy
+        has_many :promotion_rule_taxons,
+          class_name: 'Spree::PromotionRuleTaxon',
+          foreign_key: :promotion_rule_id,
+          dependent: :destroy,
+          inverse_of: :promotion_rule
         has_many :taxons, through: :promotion_rule_taxons, class_name: 'Spree::Taxon'
 
         def preload_relations

legacy_promotions/app/models/spree/promotion/rules/user.rb

@@ -4,9 +4,11 @@ module Spree
   class Promotion < Spree::Base
     module Rules
       class User < PromotionRule
-        has_many :promotion_rule_users, class_name: 'Spree::PromotionRuleUser',
-                                        foreign_key: :promotion_rule_id,
-                                        dependent: :destroy
+        has_many :promotion_rule_users,
+          class_name: 'Spree::PromotionRuleUser',
+          foreign_key: :promotion_rule_id,
+          dependent: :destroy,
+          inverse_of: :promotion_rule
         has_many :users, through: :promotion_rule_users, class_name: Spree::UserClassHandle.new
 
         def preload_relations

legacy_promotions/app/models/spree/promotion_category.rb

@@ -3,6 +3,6 @@
 module Spree
   class PromotionCategory < Spree::Base
     validates :name, presence: true
-    has_many :promotions
+    has_many :promotions, dependent: :nullify
   end
 end

legacy_promotions/app/models/spree/promotion_code.rb

@@ -3,7 +3,7 @@
 class Spree::PromotionCode < Spree::Base
   belongs_to :promotion, inverse_of: :codes, optional: true
   belongs_to :promotion_code_batch, class_name: "Spree::PromotionCodeBatch", optional: true
-  has_many :adjustments
+  has_many :adjustments, dependent: :restrict_with_error
 
   before_validation :normalize_code