Test InMemoryOrder updater in legacy promotions

Integration level test using the InMemoryOrderUpdater to ensure we are
not persisting changes during the promotion recalculations.

Co-authored-by: Chris <chris@super.gd>
Co-authored-by: Benjamin <benjamin@super.gd>
Co-authored-by: An <andrew@super.gd>
Co-authored-by: Jared <jared@super.gd>

Author: 5 people

legacy_promotions/spec/models/spree/promotion/order_adjustments_recalculator_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-require 'db-query-matchers'
 
 RSpec.describe Spree::Promotion::OrderAdjustmentsRecalculator do
   subject { described_class.new(order).call(persist:) }

legacy_promotions/spec/models/spree/promotion_integration_spec.rb

@@ -84,6 +84,13 @@
   end
 
   describe "distributing amount across line items" do
+    subject {
+      calculator.preferred_amount = 15
+      Spree::Promotion::Actions::CreateItemAdjustments.create!(calculator:, promotion:)
+
+      order.recalculate
+    }
+
     let(:calculator) { Spree::Calculator::DistributedAmount.new }
     let(:promotion) {
       create :promotion,
@@ -95,21 +102,52 @@
         line_items_attributes: [{ price: 20 }, { price: 30 }, { price: 100 }]
     }
 
-    before do
-      calculator.preferred_amount = 15
-      Spree::Promotion::Actions::CreateItemAdjustments.create!(calculator:, promotion:)
-      order.recalculate
-    end
-
     it 'correctly distributes the entire discount' do
+      subject
+
       expect(order.promo_total).to eq(-15)
       expect(order.line_items.map(&:adjustment_total)).to eq([-2, -3, -10])
     end
 
+    context 'with the in memory order updater' do
+      subject {
+        calculator.preferred_amount = 15
+        Spree::Promotion::Actions::CreateItemAdjustments.create!(calculator:, promotion:)
+
+        order.recalculate(persist: false)
+      }
+
+      around do |example|
+        default_order_recalculator = Spree::Config.order_recalculator_class.to_s
+
+        Spree::Config.order_recalculator_class = 'Spree::InMemoryOrderUpdater'
+
+        example.run
+
+        Spree::Config.order_recalculator_class = default_order_recalculator
+      end
+
+      it 'initializes the adjustments but does not persist them' do
+        subject
+
+        expect(order.promo_total).to eq(-15)
+        expect(order.line_items.map(&:adjustment_total)).to eq([-2, -3, -10])
+
+        order.reload
+
+        expect(order.promo_total).to eq(0)
+        expect(order.line_items.map(&:adjustment_total)).to eq([0, 0, 0])
+      end
+    end
+
     context 'with product promotion rule' do
+      subject { order.recalculate }
+
       let(:first_product) { order.line_items.first.product }
 
       before do
+        calculator.preferred_amount = 15
+        Spree::Promotion::Actions::CreateItemAdjustments.create!(calculator:, promotion:)
         rule = Spree::Promotion::Rules::Product.create!(
           promotion:,
           product_promotion_rules: [
@@ -118,10 +156,11 @@
         )
         promotion.rules << rule
         promotion.save!
-        order.recalculate
       end
 
       it 'still distributes the entire discount' do
+        subject
+
         expect(order.promo_total).to eq(-15)
         expect(order.line_items.map(&:adjustment_total)).to eq([-15, 0, 0])
       end

legacy_promotions/spec/rails_helper.rb

@@ -27,6 +27,7 @@
 require 'rspec/rails'
 require 'rspec-activemodel-mocks'
 require 'database_cleaner'
+require 'db-query-matchers'
 
 Dir["./spec/support/**/*.rb"].sort.each { |f| require f }