Stop passing line_item to compute unit cancelation adjustment's amount#5278
Closed
BenMorganIO wants to merge 1 commit intosolidusio:mainfrom
Closed
Stop passing line_item to compute unit cancelation adjustment's amount#5278BenMorganIO wants to merge 1 commit intosolidusio:mainfrom
BenMorganIO wants to merge 1 commit intosolidusio:mainfrom
Conversation
github-actions
bot
added
the
changelog:solidus_core
BenMorganIO
force-pushed
the
unit-cancel-improvements
branch
from
89d91bd to
0e5582f
Compare
kennyadsl
reviewed
Jul 25, 2023
| raise "Adjustable does not match line item" unless line_item == inventory_unit.line_item | ||
|
|
||
| -weighted_line_item_amount(line_item) | ||
| def compute_amount |
Member
There was a problem hiding this comment.
compute_amount is a public method. We have two ways of handling the change of the signature of a public method:
- Rename the method and deprecate
compute_amount, delegating its usage to the new method. - Keep
compute_amountwith the same signature but make the argument optional and deprecate its usage.
I think it works both ways, up to you!
kennyadsl
changed the title
Member
|
Closing because there haven't been any updates in 2 years. Please re-open with the requested changes if you'd still like to have this merged! ❤️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5278 +/- ##
==========================================
+ Coverage 88.71% 93.27% +4.56%
==========================================
Files 563 123 -440
Lines 13890 3287 -10603
==========================================
- Hits 12322 3066 -9256
+ Misses 1568 221 -1347 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simple refactoring for the
Spree::UnitCancel. There's no need to doinventory_unit.line_itemand then pass the line item through everywhere when we can get it through ahas_one. I also changedweighted_amountto accept an arbitrary amount instead of a line item object.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: