Skip to content

Commit 3507863

Browse files
Merge pull request #199 from solidusio/waiting-for-dev/remove_slack_notifications
Remove Slack notifications for CI failures
2 parents 55b738c + d7f74f7 commit 3507863

File tree

3 files changed

+14
-29
lines changed

3 files changed

+14
-29
lines changed

.circleci/config.yml

Lines changed: 11 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ orbs:
66
# to change this configuration every time a Solidus version is released
77
# or goes EOL.
88
solidusio_extensions: solidusio/extensions@volatile
9-
slack: circleci/[email protected]
109

1110
commands:
1211
setup:
@@ -20,44 +19,33 @@ commands:
2019
gem install bundler -v '>=2.3.21' --conservative
2120
bundle --version
2221
23-
notify:
24-
steps:
25-
- slack/notify:
26-
event: fail
27-
template: basic_fail_1
28-
branch_pattern: master
29-
3022
jobs:
3123
solidus-master:
3224
executor:
3325
name: solidusio_extensions/sqlite
3426
ruby_version: '3.1'
35-
steps: ['setup', 'solidusio_extensions/run-tests-solidus-master', 'notify']
27+
steps: ['setup', 'solidusio_extensions/run-tests-solidus-master']
3628
solidus-current:
3729
executor:
3830
name: solidusio_extensions/sqlite
3931
ruby_version: '3.0'
40-
steps: ['setup', 'solidusio_extensions/run-tests-solidus-current', 'notify']
32+
steps: ['setup', 'solidusio_extensions/run-tests-solidus-current']
4133
solidus-older:
4234
executor:
4335
name: solidusio_extensions/sqlite
4436
ruby_version: '2.7'
45-
steps: ['setup', 'solidusio_extensions/run-tests-solidus-older', 'notify']
37+
steps: ['setup', 'solidusio_extensions/run-tests-solidus-older']
4638
lint-code:
4739
executor: solidusio_extensions/sqlite
48-
steps: ['setup', 'solidusio_extensions/lint-code', 'notify']
40+
steps: ['setup', 'solidusio_extensions/lint-code']
4941

5042
workflows:
5143
"Run specs on supported Solidus versions":
5244
jobs:
53-
- solidus-master:
54-
context: slack-secrets
55-
- solidus-current:
56-
context: slack-secrets
57-
- solidus-older:
58-
context: slack-secrets
59-
- lint-code:
60-
context: slack-secrets
45+
- solidus-master
46+
- solidus-current
47+
- solidus-older
48+
- lint-code
6149

6250
"Weekly run specs against master":
6351
triggers:
@@ -68,9 +56,6 @@ workflows:
6856
only:
6957
- master
7058
jobs:
71-
- solidus-master:
72-
context: slack-secrets
73-
- solidus-current:
74-
context: slack-secrets
75-
- solidus-older:
76-
context: slack-secrets
59+
- solidus-master
60+
- solidus-current
61+
- solidus-older

Gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ gem 'solidus', github: 'solidusio/solidus', branch: branch
1313
# A workaround for https://github.com/bundler/bundler/issues/6677
1414
gem 'rails', '>0.a'
1515

16+
gem 'bundler'
17+
gem 'rake'
18+
1619
# These gems will be used by the temporary extensions generated by tests
1720
group :test do
1821
gem 'mysql2'

solidus_dev_support.gemspec

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,4 @@ Gem::Specification.new do |spec|
4747
spec.add_dependency 'rubocop-rspec', '~> 2.0'
4848
spec.add_dependency 'solidus_core', ['>= 2.0', '< 4']
4949
spec.add_dependency 'webdrivers', '>= 4.4'
50-
51-
spec.add_development_dependency 'bundler'
52-
spec.add_development_dependency 'rake'
5350
end

0 commit comments

Comments
 (0)