fix: Remove services

GitHub composite actions do not
support starting services. The calling
workflow needs to handle this.

Currently all our extensions that test
multiple database actually test with
SQLite all the time.

Adding examples and more documentation
to README. We now need to update all
extensions that use this action manually

Author: tvdeyen

README.md

@@ -2,6 +2,21 @@
 
 A GitHub action for testing Solidus extensions
 
+## Inputs
+
+| Input | Description | Required | Default |
+|-------|-------------|----------|---------|
+| `ruby-version` | Ruby version to use | Yes | `3.3` |
+| `rails-version` | Rails version to use | Yes | `7.2` |
+| `solidus-branch` | Solidus branch to use | Yes | `main` |
+| `database` | Database to use (`sqlite3`, `postgresql`, or `mariadb`) | Yes | `sqlite3` |
+
+## Database Services
+
+This is a composite GitHub Action, which means it **cannot define services directly**. If you need to test against PostgreSQL or MySQL/MariaDB, you must define the database service in your workflow file.
+
+The action will install the necessary database client libraries automatically based on the `database` input.
+
 ## Example configuration
 
 ```yaml
@@ -12,54 +27,41 @@ on:
     branches:
       - main
   pull_request:
-  schedule:
-    - cron: "0 0 * * 4" # every Thursday
-
-concurrency:
-  group: test-${{ github.ref_name }}
-  cancel-in-progress: ${{ github.ref_name != 'main' }}
-
-permissions:
-  contents: read
 
 jobs:
-  rspec:
-    name: Solidus ${{ matrix.solidus-branch }}, Rails ${{ matrix.rails-version }} and Ruby ${{ matrix.ruby-version }} on ${{ matrix.database }}
+  test:
+    name: ${{ matrix.database }} - Solidus ${{ matrix.solidus-branch }}, Rails ${{ matrix.rails-version }}, Ruby ${{ matrix.ruby-version }}
     runs-on: ubuntu-24.04
+    services:
+      postgres:
+        image: postgres:16
+        env:
+          POSTGRES_HOST_AUTH_METHOD: trust
+        options: >-
+          --health-cmd="pg_isready"
+          --health-interval=10s
+          --health-timeout=5s
+          --health-retries=5
+        ports:
+          - 5432:5432
+      mysql:
+        image: mysql:8.0
+        env:
+          MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
+        options: >-
+          --health-cmd="mysqladmin ping"
+          --health-interval=10s
+          --health-timeout=5s
+          --health-retries=5
+        ports:
+          - 3306:3306
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
-        rails-version:
-          - "7.0"
-          - "7.1"
-          - "7.2"
-        ruby-version:
-          - "3.1"
-          - "3.4"
-        solidus-branch:
-          - "v4.1"
-          - "v4.2"
-          - "v4.3"
-          - "v4.4"
-        database:
-          - "postgresql"
-          - "mysql"
-          - "sqlite"
-        exclude:
-          - rails-version: "7.2"
-            solidus-branch: "v4.3"
-          - rails-version: "7.2"
-            solidus-branch: "v4.2"
-          - rails-version: "7.2"
-            solidus-branch: "v4.1"
-          - rails-version: "7.1"
-            solidus-branch: "v4.2"
-          - rails-version: "7.1"
-            solidus-branch: "v4.1"
-          - ruby-version: "3.4"
-            rails-version: "7.0"
-    env:
-      TEST_RESULTS_PATH: coverage/coverage.xml
+        database: ["sqlite3", "postgresql", "mariadb"]
+        rails-version: ["7.1", "7.2"]
+        ruby-version: ["3.2", "3.3"]
+        solidus-branch: ["v4.3", "v4.4"]
     steps:
       - uses: actions/checkout@v4
       - name: Run extension tests
@@ -69,11 +71,4 @@ jobs:
           rails-version: ${{ matrix.rails-version }}
           ruby-version: ${{ matrix.ruby-version }}
           solidus-branch: ${{ matrix.solidus-branch }}
-      - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v5
-        continue-on-error: true
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          files: ${{ env.TEST_RESULTS_PATH }}
-
 ```

action.yml

@@ -19,25 +19,6 @@ inputs:
     required: true
     default: "3.3"
 
-services:
-  postgres:
-    image: postgres:latest
-    env:
-      POSTGRES_USER: solidus_user
-      POSTGRES_PASSWORD: password
-      POSTGRES_DB: solidus_extension_test
-    ports: ["5432:5432"]
-    options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
-  mariadb:
-    image: mariadb:latest
-    ports: ["3307:3306"]
-    env:
-      MARIADB_USER: solidus_user
-      MARIADB_PASSWORD: password
-      MARIADB_DATABASE: solidus_extension_test
-      MARIADB_ROOT_PASSWORD: password
-    options: --health-cmd="mariadb-admin ping" --health-interval=10s --health-timeout=5s --health-retries=5
-
 runs:
   using: "composite"
   steps:
@@ -46,6 +27,8 @@ runs:
       uses: ruby/setup-ruby@v1
       env:
         DB: ${{ inputs.database }}
+        DB_HOST: 127.0.0.1
+        DB_USERNAME: root
         RAILS_VERSION: ${{ inputs.rails-version }}
         SOLIDUS_BRANCH: ${{ inputs.solidus-branch }}
       with:
@@ -88,6 +71,8 @@ runs:
       shell: bash
       env:
         DB: ${{ inputs.database }}
+        DB_HOST: 127.0.0.1
+        DB_USERNAME: root
         RAILS_VERSION: ${{ inputs.rails-version }}
         SOLIDUS_BRANCH: ${{ inputs.solidus-branch }}
       run: |