Skip to content

Commit 05c82ff

Browse files
committed
use underscores for redirect routes
1 parent 022d870 commit 05c82ff

File tree

4 files changed

+20
-26
lines changed

4 files changed

+20
-26
lines changed

test/fixtures/site 1/redirects.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
"to": "/",
1919
"permanent": true
2020
}, {
21-
"from": "/overridden-route",
22-
"to": "/overridden-redirect"
23-
}, {
24-
"from": "/",
25-
"to": "/overridden-index-redirect"
21+
"from": "/overridden_route",
22+
"to": "/overridden_redirect"
2623
}]

test/fixtures/site 1/views/overridden-route.hbs

Whitespace-only changes.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
This route should be overridden

test/solidus.js

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -74,33 +74,33 @@ describe( 'Solidus', function(){
7474
var redirect_date_format = 'YYYY-MM-DD HH:mm:ss';
7575
var temporal_redirects = [{
7676
start: moment().add( 's', 5 ).format( redirect_date_format ),
77-
from: '/future-redirect',
77+
from: '/future_redirect',
7878
to: '/'
7979
}, {
8080
start: moment().subtract( 's', 5 ).format( redirect_date_format ),
8181
end: moment().add( 's', 5 ).format( redirect_date_format ),
82-
from: '/current-redirect',
82+
from: '/current_redirect',
8383
to: '/'
8484
}, {
8585
start: moment().subtract( 's', 10 ).format( redirect_date_format ),
8686
end: moment().subtract( 's', 5 ).format( redirect_date_format ),
87-
from: '/past-redirect',
87+
from: '/past_redirect',
8888
to: '/'
8989
}];
9090
var overlapping_redirects = [{
9191
start: moment().add( 's', 5 ).format( redirect_date_format ),
92-
from: '/overlapping-redirect',
93-
to: '/overlapping-redirect-future'
92+
from: '/overlapping_redirect',
93+
to: '/overlapping_redirect_future'
9494
}, {
9595
start: moment().subtract( 's', 5 ).format( redirect_date_format ),
9696
end: moment().add( 's', 5 ).format( redirect_date_format ),
97-
from: '/overlapping-redirect',
98-
to: '/overlapping-redirect-current'
97+
from: '/overlapping_redirect',
98+
to: '/overlapping_redirect_current'
9999
}, {
100100
start: moment().subtract( 's', 10 ).format( redirect_date_format ),
101101
end: moment().subtract( 's', 5 ).format( redirect_date_format ),
102-
from: '/overlapping-redirect',
103-
to: '/overlapping-redirect-past'
102+
from: '/overlapping_redirect',
103+
to: '/overlapping_redirect_past'
104104
}];
105105
var combined_redirects = JSON.stringify( original_redirects_arr.concat( temporal_redirects, overlapping_redirects ) );
106106
fs.writeFileSync( 'redirects.json', combined_redirects, DEFAULT_ENCODING );
@@ -331,16 +331,16 @@ describe( 'Solidus', function(){
331331
s_request.get('/redirect5').expect( 301, callback );
332332
},
333333
function( callback ){
334-
s_request.get('/past-redirect').expect( 404, callback );
334+
s_request.get('/past_redirect').expect( 404, callback );
335335
},
336336
function( callback ){
337-
s_request.get('/current-redirect').expect( 302, callback );
337+
s_request.get('/current_redirect').expect( 302, callback );
338338
},
339339
function( callback ){
340-
s_request.get('/future-redirect').expect( 404, callback );
340+
s_request.get('/future_redirect').expect( 404, callback );
341341
},
342342
function( callback ){
343-
s_request.get('/overlapping-redirect').expect( 'location', '/overlapping-redirect-current', callback );
343+
s_request.get('/overlapping_redirect').expect( 'location', '/overlapping_redirect_current', callback );
344344
}
345345
], function( err, results ){
346346
if( err ) throw err;
@@ -352,15 +352,11 @@ describe( 'Solidus', function(){
352352
s_request = request( solidus_server.router );
353353
async.parallel([
354354
function( cb ){
355-
s_request.get('/overridden-route')
355+
s_request.get('/overridden_route')
356356
.expect( 302 )
357-
.expect( 'location', '/overridden-redirect', cb );
358-
},
359-
function( cb ){
360-
s_request.get('/')
361-
.expect( 302 )
362-
.expect( 'location', '/overridden-index-redirect', cb );
363-
}],
357+
.expect( 'location', '/overridden_redirect', cb );
358+
}
359+
],
364360
function( err, results ){
365361
if( err ) throw err;
366362
done();

0 commit comments

Comments
 (0)