cleancode

Author: ueaner

README.md

@@ -143,7 +143,7 @@ worker 进程会自动在其后追加 worker 文本，最终的进程名称为 `
 
 worker 进程退出后是否自动补充新的进程，`默认为 true，自动补充新的进程`。
 
-如果不想自动补充退出的进程，请可以设置 `refork` 为 `false;`
+如果不想自动补充退出的进程，可以设置 `refork` 为 `false;`
 
 
 ## 信号处理

src/Process.php

@@ -68,7 +68,6 @@ protected function forkWorker($id)
             static::$isMaster = false;
             $this->id = $id;
             $this->workerPid = posix_getpid();
-
             $this->setProcName();
 
             // Run worker.
@@ -122,7 +121,7 @@ protected function redirectStd()
         fclose(STDOUT);
         fclose(STDERR);
 
-        $logFile = $this->logFile ? $this->logFile : '/dev/null';
+        $logFile = $this->logFile ?: '/dev/null';
 
         global $stdin, $stdout, $stderr;
         $stdin = fopen('/dev/null', 'r');
@@ -167,7 +166,7 @@ protected function setProcName()
 
     protected function run()
     {
-        register_shutdown_function([$this, 'handleShutdown']);
+        register_shutdown_function([$this, 'handleFatalError']);
 
         try {
             $this->log("[worker:{$this->id} {$this->workerPid}] process started");
@@ -179,7 +178,7 @@ protected function run()
         }
     }
 
-    public function handleShutdown()
+    public function handleFatalError()
     {
         $errmsg = "[worker:{$this->id} {$this->workerPid}] process terminated";
         // Handle last error.