feat: arangodb driver clean code

Author: Olivier Bonnaure

.lua/arangodb.lua

@@ -1,13 +1,15 @@
 Adb = {}
 Adb.__index = Adb
 
-function Adb.new()
+function Adb.new(db_config)
   local self = setmetatable({}, Adb)
 
   self._lastDBConnect = GetTime()
+  self._db_config = db_config
   self._arangoAPI = ""
   self._arangoJWT = ""
-  self._db_config = null
+
+  self:Auth()
 
   return self
 end
@@ -16,11 +18,6 @@ function Adb:Api_url(path)
   return self._arangoAPI .. path
 end
 
-function Adb:infos()
-  print(self._arangoAPI)
-  print(self._arangoJWT)
-end
-
 function Adb:Api_run(path, method, params, headers)
   params = params or {}
   headers = headers or {}
@@ -36,22 +33,18 @@ function Adb:Api_run(path, method, params, headers)
   return DecodeJson(body), ok, h
 end
 
-function Adb:Auth(db_config)
-  print(EncodeJson(db_config))
-  if self._db_config == null then self._db_config = db_config end
-
+function Adb:Auth()
   local ok, headers, body =
       Fetch(
-        db_config.url .. "/_open/auth",
+        self._db_config.url .. "/_open/auth",
         {
           method = "POST",
           body = '{ "username": "' .. self._db_config.username .. '", "password": "' .. self._db_config.password .. '" }'
         }
       )
 
   self._arangoAPI = self._db_config.url .. "/_db/" .. self._db_config.db_name .. "/_api"
-  print(self._arangoAPI)
-  print(BeansEnv)
+
   if ok == 200 then
     self._arangoJWT = DecodeJson(body)["jwt"]
   end

.lua/luaonbeans.lua

@@ -349,8 +349,8 @@ function InitDB(db_config)
       PGRest[config.name] = _PGRest
     elseif (config.engine == "arangodb") then
       local _Adb = require("arangodb")
-      local adb_driver = _Adb.new()
-      adb_driver:Auth(config)
+      local adb_driver = _Adb.new(config)
+      adb_driver:Auth()
       adb_driver:UpdateCacheConfiguration({ mode = "on" })
       Adb[config.name] = adb_driver
     elseif (config.engine == "db2rest") then

beans.lua

@@ -122,15 +122,15 @@ SetupArangoDB = function(env)
   Adb = {}
   _Adb = require "arangodb"
   for _, config in pairs(DBConfig[BeansEnv]) do
-    local adb_driver = _Adb.new()
-    adb_driver:Auth(config)
+    local adb_driver = _Adb.new(config)
+    adb_driver:Auth()
     Adb[config.name] = adb_driver
   end
 
   if DBConfig["system"] then
     _Adb = require "arangodb"
-    local adb_driver = _Adb.new()
-    adb_driver:Auth(DBConfig["system"])
+    local adb_driver = _Adb.new(DBConfig["system"])
+    adb_driver:Auth()
     Adb.system = adb_driver
   end
 

specs/arangodb_spec.lua

@@ -26,7 +26,6 @@ return {
 
 			describe("CreateDocument", function()
 				it("create document", function()
-					print(Adb.primary:infos())
 					local collection = Adb.primary:CreateCollection("test_data")
 					expect.truthy(collection.code == 200)