ProcessFake

Author: deleugpn

app/Http/Controllers/Modules/FirewallController.php

@@ -2,7 +2,7 @@
 
 namespace App\Http\Controllers\Modules;
 
-use App\Process;
+use Facades\App\Process;
 use Facades\App\Disk;
 use App\Http\Controllers\Controller;
 use App\Models\Expressive\Firewall;

app/Process.php

@@ -8,20 +8,20 @@
 
 class Process
 {
-    public static function deploy()
+    public function deploy()
     {
         // @TODO: test if I can just use ./vendor/bin/envoy
         $command = base_path('/vendor/bin/envoy') . ' run deploy';
 
-        return (new Process)->run($command);
+        return $this->run($command);
     }
 
-    public static function firewall()
+    public function firewall()
     {
-        return (new Process)->run('/etc/rc.d/rc.firewall', '/');
+        return $this->run('/etc/rc.d/rc.firewall', '/');
     }
 
-    public function run($command, $directory = null)
+    protected function run($command, $directory = null)
     {
         $directory = $directory ?: base_path();
 

config/app.php

@@ -15,7 +15,7 @@
 
     'name' => env('APP_NAME', 'Thunderwall'),
 
-    'version' => '0.0.8',
+    'version' => '0.0.9',
 
     /*
     |--------------------------------------------------------------------------

tests/Fake/FakeDisk.php tests/Fake/DiskFake.phptests/Fake/FakeDisk.php renamed to tests/Fake/DiskFake.php

@@ -4,7 +4,7 @@
 
 use App\Disk;
 
-class FakeDisk extends Disk
+class DiskFake extends Disk
 {
 
     /**

tests/Fake/ProcessFake.php

@@ -12,7 +12,7 @@ class ProcessFake extends Process
      */
     protected $commands = [];
 
-    public function run($command, $directory = null)
+    protected function run($command, $directory = null)
     {
         $this->commands[] = $command;
     }

tests/Feature/AuthenticatedTestCase.php

@@ -6,7 +6,7 @@
 use Facades\App\Disk;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Support\Facades\Cache;
-use Tests\Fake\FakeDisk;
+use Tests\Fake\DiskFake;
 
 abstract class AuthenticatedTestCase extends DatabaseTestCase
 {
@@ -22,11 +22,5 @@ protected function setUp()
         parent::setUp();
 
         $this->actingAs($this->user = create(User::class));
-
-        // Redirect any file creation to /storage/tests
-        Disk::swap(new FakeDisk);
-
-        // Avoid GitHub API by Default
-        Cache::put('updateAvailable', false, 1);
     }
 }

tests/Feature/Firewall/FirewallTest.php

@@ -3,6 +3,7 @@
 namespace Tests\Feature;
 
 use App\Models\Expressive\Firewall;
+use Facades\App\Process;
 use Tests\AuthenticatedTestCase;
 
 class FirewallTest extends AuthenticatedTestCase
@@ -30,5 +31,6 @@ public function a_user_can_change_the_firewall_settings()
             ->assertSessionHas('success');
 
         $this->assertDatabaseHas('sections', ['file_id' => $file->id, 'content' => $content]);
+        Process::assertExecuted('/etc/rc.d/rc.firewall');
     }
 }

tests/TestCase.php

@@ -3,9 +3,14 @@
 namespace Tests;
 
 use App\Models\User;
+use Facades\App\Process;
+use Facades\App\Disk;
 use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
 use Illuminate\Foundation\Testing\TestResponse;
 use Illuminate\Http\Response;
+use Illuminate\Support\Facades\Cache;
+use Tests\Fake\DiskFake;
+use Tests\Fake\ProcessFake;
 
 abstract class TestCase extends BaseTestCase
 {
@@ -32,6 +37,14 @@ protected function setUp()
 
             return $this;
         });
+
+        // Redirect any file creation to /storage/tests
+        Disk::swap(new DiskFake);
+
+        Process::swap(new ProcessFake);
+
+        // Avoid GitHub API by Default
+        Cache::put('updateAvailable', false, 1);
     }
 
     public function signIn(User $user = null)