Skip to content

Commit a7b41f2

Browse files
author
Tobias Wojtylak
committed
removed skippable option for steps
1 parent 65878b1 commit a7b41f2

File tree

6 files changed

+0
-32
lines changed

6 files changed

+0
-32
lines changed

spec/Factory/MultiStepFactorySpec.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ function it_can_create_step(StepRequiredCheckerInterface $stepRequiredChecker)
2727
'slug' => 'TestSlug',
2828
'template' => 'TestTemplate',
2929
'controller' => 'TestController',
30-
'skippable' => true,
3130
'stepRequiredChecker' => $stepRequiredChecker
3231
];
3332

@@ -37,7 +36,6 @@ function it_can_create_step(StepRequiredCheckerInterface $stepRequiredChecker)
3736
$step->getSlug()->shouldReturn('TestSlug');
3837
$step->getTemplate()->shouldReturn('TestTemplate');
3938
$step->getControllerAction()->shouldReturn('TestController');
40-
$step->isSkippable()->shouldReturn(true);
4139
$step->getStepRequiredChecker()->shouldReturn($stepRequiredChecker);
4240
}
4341
}

spec/Model/MultiStepSpec.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,6 @@ function it_has_controller_action()
6161
$this->getControllerAction()->shouldReturn($value);
6262
}
6363

64-
function it_is_not_skippable()
65-
{
66-
$this->isSkippable()->shouldReturn(false);
67-
}
68-
69-
function it_is_skippable()
70-
{
71-
$this->setSkippable(true);
72-
$this->isSkippable()->shouldReturn(true);
73-
}
74-
7564
function it_has_step_required_checker(StepRequiredCheckerInterface $stepRequiredChecker)
7665
{
7766
$this->setStepRequiredChecker($stepRequiredChecker);

src/DependencyInjection/Configuration.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public function getConfigTreeBuilder()
3939
'solutionDrive\MultiStepBundle\Controller\DefaultStepController::renderAction'
4040
)
4141
->end()
42-
->booleanNode('skippable')->defaultFalse()->end()
4342
->scalarNode('stepRequiredChecker')
4443
->defaultValue('sd.multistep.step_checker.default')
4544
->end()

src/Factory/MultiStepFactory.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ public function createFromConfig(string $id, array $config): MultiStepInterface
2626
$step->setSlug($config['slug']);
2727
$step->setTemplate($config['template']);
2828
$step->setControllerAction($config['controller']);
29-
$step->setSkippable((bool) $config['skippable']);
3029
$step->setStepRequiredChecker($config['stepRequiredChecker']);
3130
return $step;
3231
}

src/Model/MultiStep.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ class MultiStep implements MultiStepInterface
2828
/** @var string */
2929
private $controllerAction = '';
3030

31-
/** @var bool */
32-
private $skippable = false;
33-
3431
/** @var StepRequiredCheckerInterface */
3532
private $stepRequiredChecker;
3633

@@ -84,16 +81,6 @@ public function setControllerAction(string $controllerAction): void
8481
$this->controllerAction = $controllerAction;
8582
}
8683

87-
public function isSkippable(): bool
88-
{
89-
return $this->skippable;
90-
}
91-
92-
public function setSkippable(bool $skippable): void
93-
{
94-
$this->skippable = $skippable;
95-
}
96-
9784
public function getStepRequiredChecker(): StepRequiredCheckerInterface
9885
{
9986
return $this->stepRequiredChecker;

src/Model/MultiStepInterface.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ public function getControllerAction(): string;
3232

3333
public function setControllerAction(string $controllerAction): void;
3434

35-
public function isSkippable(): bool;
36-
37-
public function setSkippable(bool $skippable): void;
38-
3935
public function getStepRequiredChecker(): StepRequiredCheckerInterface;
4036

4137
public function setStepRequiredChecker(StepRequiredCheckerInterface $stepRequiredChecker): void;

0 commit comments

Comments
 (0)