Skip to content

Commit 431a490

Browse files
authored
[style] Use is to compare types (#2317)
1 parent dbaa377 commit 431a490

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

fixcore/fixcore/model/typed_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def type_fqn(tpe: type) -> str:
2525

2626

2727
def from_js(json: JsonElement, clazz: Type[AnyT]) -> AnyT:
28-
return jsons.load(json, cls=clazz) if clazz != dict else json # type: ignore
28+
return jsons.load(json, cls=clazz) if clazz is not dict else json # type: ignore
2929

3030

3131
def to_js(node: Any, **kwargs: Any) -> Json:

fixlib/test/core/model_export_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ def test_collection() -> None:
8383
assert is_collection(list) is True
8484
assert is_collection(dict) is False
8585

86-
assert type_arg(Optional[List[int]]) == int
87-
assert type_arg(List[datetime]) == datetime
86+
assert type_arg(Optional[List[int]]) is int
87+
assert type_arg(List[datetime]) is datetime
8888

8989

9090
def test_dictionary() -> None:

plugins/azure/tools/azure_model_gen.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ def fill_sequence(seq, index, value_index_type):
539539
while len(seq) < index:
540540
seq.append(None)
541541

542-
if value_index_type == int:
542+
if value_index_type is int:
543543
seq.append([])
544544
elif value_index_type is None:
545545
seq.append(None)

0 commit comments

Comments
 (0)