Skip to content

Commit 4d5ef34

Browse files
authored
Merge pull request #877 from jbonnet/859-POST-licences-fails
Fixed user name to user id in finding licences, removed extra user va…
2 parents 8b2ad52 + e970dda commit 4d5ef34

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

son-gtkapi/helpers/common.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@ def validate_ownership_and_licence(element:, user_name:, kpi_method:, began_at:,
155155
return
156156
end
157157

158-
licenced_elements = LicenceManagerService.find({service_uuid: element[:uuid], user_uuid: user_name})
158+
user_uuid = User.find_by_name(user_name)[:uuid]
159+
licenced_elements = LicenceManagerService.find({service_uuid: element[:uuid], user_uuid: user_uuid})
159160
if licenced_elements[:items].empty?
160161
# there's no licence for this element for this username
161162
kpi_method.call(labels: {result: "forbidden", uuid: element[:uuid], elapsed_time: (Time.now.utc-began_at).to_s}) if kpi_method
@@ -200,7 +201,8 @@ def enhance_collection(collection:, user:, keys_to_delete:)
200201
next
201202
end
202203

203-
licenced_collection = LicenceManagerService.find({service_uuid: element[:uuid], user_uuid: user})
204+
user_uuid = User.find_by_name(user)[:uuid]
205+
licenced_collection = LicenceManagerService.find({service_uuid: element[:uuid], user_uuid: user_uuid})
204206
logger.debug(log_message) {"licenced_collection=#{licenced_collection}"}
205207

206208

son-gtkapi/models/licence_manager_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def self.valid?(params)
5050

5151
method = LOG_MESSAGE + "##{__method__}"
5252
GtkApi.logger.debug(method) {"entered: params=#{params}"}
53-
raise ArgumentError, 'User must be valid' unless User.valid? params[:user_uuid]
53+
#raise ArgumentError, 'User must be valid' unless User.valid? params[:user_uuid]
5454
raise ArgumentError, 'Service must be valid' unless ServiceManagerService.valid? params[:service_uuid]
5555
GtkApi.logger.debug(method) {"Leaving with valid licence data service #{params[:service_uuid]} and user #{params[:user_uuid]}"}
5656
true

0 commit comments

Comments
 (0)