Skip to content

Commit 0815fc0

Browse files
authored
Merge pull request #237 from tsoenen/master
Fix for keyerror on IA WAN call. Error handling for IA WAN call.
2 parents a35bc4b + 9d4ce89 commit 0815fc0

File tree

1 file changed

+14
-7
lines changed
  • plugins/son-mano-service-lifecycle-management/son_mano_slm

1 file changed

+14
-7
lines changed

plugins/son-mano-service-lifecycle-management/son_mano_slm/slm.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1876,10 +1876,14 @@ def wan_configure_response(self, ch, method, prop, payload):
18761876
serv_id = tools.servid_from_corrid(self.services, prop.correlation_id)
18771877

18781878
message = yaml.load(payload)
1879-
self.services[serv_id]['status'] = message['status']
1880-
self.services[serv_id]['error'] = None
18811879

1882-
# TODO: handle negative status
1880+
LOG.info("Service " + serv_id + ": WAN configure request completed.")
1881+
1882+
if message['message'] != '':
1883+
error = message['message']
1884+
LOG.info('Error occured during WAN: ' + str(error))
1885+
self.error_handling(serv_id, t.GK_CREATE, error)
1886+
18831887
self.start_next_task(serv_id)
18841888

18851889
def wan_deconfigure(self, serv_id):
@@ -1899,7 +1903,6 @@ def wan_deconfigure(self, serv_id):
18991903
yaml.dump(message),
19001904
correlation_id=corr_id)
19011905

1902-
19031906
def wan_deconfigure_response(self, ch, method, prop, payload):
19041907
"""
19051908
This method handles responses on the wan_deconfigure call
@@ -1909,10 +1912,14 @@ def wan_deconfigure_response(self, ch, method, prop, payload):
19091912
serv_id = tools.servid_from_corrid(self.services, prop.correlation_id)
19101913

19111914
message = yaml.load(payload)
1912-
self.services[serv_id]['status'] = message['status']
1913-
self.services[serv_id]['error'] = None
19141915

1915-
# TODO: handle negative status
1916+
LOG.info("Service " + serv_id + ": WAN deconfigure request completed.")
1917+
1918+
if message['message'] != '':
1919+
error = message['message']
1920+
LOG.info('Error occured during deconfiguring WAN: ' + str(error))
1921+
self.error_handling(serv_id, t.GK_KILL, error)
1922+
19161923
self.start_next_task(serv_id)
19171924

19181925
def stop_monitoring(self, serv_id):

0 commit comments

Comments
 (0)