fix(form): Error messages displayed twice with form type "sonata_type_native_collection" or "sonata_type_immutable_array" when "error_bubbling" sets to false (#8335)

Author: sad270

src/Resources/views/Form/form_admin_fields.html.twig

@@ -402,7 +402,6 @@ file that was distributed with this source code.
         {% set allow_delete = allow_delete_backup %}
     {% endif %}
     <div {{ block('widget_container_attributes') }}>
-        {{ form_errors(form) }}
         {% for child in form %}
             {{ block('sonata_type_native_collection_widget_row') }}
         {% endfor %}
@@ -419,8 +418,6 @@ file that was distributed with this source code.
     <div {{ block('widget_container_attributes') }}>
         {{ form_help(form) }}
 
-        {{ form_errors(form) }}
-
         {% for key, child in form %}
             {{ block('sonata_type_immutable_array_widget_row') }}
         {% endfor %}

tests/App/Admin/FooAdmin.php

@@ -19,13 +19,18 @@
 use Sonata\AdminBundle\Datagrid\ListMapper;
 use Sonata\AdminBundle\FieldDescription\FieldDescriptionInterface;
 use Sonata\AdminBundle\Form\FormMapper;
+use Sonata\AdminBundle\Form\Type\CollectionType;
 use Sonata\AdminBundle\Form\Type\ModelAutocompleteType;
 use Sonata\AdminBundle\Form\Type\TemplateType;
 use Sonata\AdminBundle\Show\ShowMapper;
 use Sonata\AdminBundle\Tests\App\Model\Bar;
 use Sonata\AdminBundle\Tests\App\Model\Foo;
 use Sonata\AdminBundle\Tests\Fixtures\Controller\BatchOtherController;
+use Sonata\Form\Type\ImmutableArrayType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
+use Symfony\Component\Validator\Constraints\Collection;
+use Symfony\Component\Validator\Constraints\Count;
+use Symfony\Component\Validator\Constraints\NotBlank;
 
 /**
  * @phpstan-extends AbstractAdmin<Foo>
@@ -65,6 +70,45 @@ protected function configureFormFields(FormMapper $form): void
                 [
                     'admin_code' => 'sonata_bar_admin',
                 ]
+            )
+            ->add(
+                'elements',
+                ImmutableArrayType::class,
+                [
+                    'help' => 'elements help message',
+                    'error_bubbling' => false,
+                    'constraints' => [
+                        new Collection([
+                            'fields' => [
+                                'elements_item' => new NotBlank(),
+                                'missing_field' => new NotBlank(),
+                            ],
+                            'allowMissingFields' => false,
+                        ]),
+                    ],
+                    'keys' => [
+                        [
+                            'elements_item',
+                            TextType::class,
+                            [
+                                'help' => 'elements_item help message',
+                            ],
+                        ],
+                    ],
+                ],
+            )
+            ->add(
+                'collection',
+                CollectionType::class,
+                [
+                    'error_bubbling' => false,
+                    'constraints' => [
+                        new Count([
+                            'min' => 2,
+                        ]),
+                    ],
+                    'entry_type' => TextType::class,
+                ],
             );
     }
 

tests/App/Model/Foo.php

@@ -18,12 +18,18 @@ final class Foo implements EntityInterface
     private ?Bar $referenced;
 
     /**
-     * @param string[] $elements
+     * @var array<string, string>
      */
+    private array $elements = [];
+
+    /**
+     * @var string[]
+     */
+    private array $collection = [];
+
     public function __construct(
         private string $id,
         private string $name,
-        private array $elements = [],
     ) {
         $this->referenced = null;
     }
@@ -49,10 +55,34 @@ public function getReferenced(): ?Bar
     }
 
     /**
-     * @return string[]
+     * @param array<string, string> $elements
+     */
+    public function setElements(array $elements): void
+    {
+        $this->elements = $elements;
+    }
+
+    /**
+     * @return array<string, string>
      */
     public function getElements(): array
     {
         return $this->elements;
     }
+
+    /**
+     * @param string[] $collection
+     */
+    public function setCollection(array $collection): void
+    {
+        $this->collection = $collection;
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getCollection(): array
+    {
+        return $this->collection;
+    }
 }

tests/Functional/Controller/CRUDControllerTest.php

@@ -47,6 +47,35 @@ public function testCreate(): void
         );
     }
 
+    public function testImmutableArrayErrorMessageIsDisplayOnce(): void
+    {
+        $client = static::createClient();
+        $client->followRedirects();
+        $client->setMaxRedirects(1);
+        $client->request(Request::METHOD_GET, '/admin/tests/app/foo/create', ['with_form_errors' => '1']);
+        $crawler = $client->submitForm('Create', []);
+        file_put_contents('tmp.html', $crawler->html());
+        static::assertSame(Response::HTTP_OK, $client->getResponse()->getStatusCode());
+        static::assertCount(
+            1,
+            $crawler->filter('.sonata-ba-field li:contains("This field is missing.")')
+        );
+    }
+
+    public function testCollectionErrorMessageIsDisplayOnce(): void
+    {
+        $client = static::createClient();
+        $client->followRedirects();
+        $client->setMaxRedirects(1);
+        $client->request(Request::METHOD_GET, '/admin/tests/app/foo/create', ['with_form_errors' => '1']);
+        $crawler = $client->submitForm('Create', []);
+        static::assertSame(Response::HTTP_OK, $client->getResponse()->getStatusCode());
+        static::assertCount(
+            1,
+            $crawler->filter('.sonata-ba-field li:contains("This collection should contain 2 elements or more.")')
+        );
+    }
+
     /**
      * https://github.com/sonata-project/SonataAdminBundle/issues/6904.
      */