DevKit updates for 4.x branch (#1785)

* DevKit updates

* DevKit updates

* Fix

---------

Co-authored-by: Vincent Langlet <[email protected]>

Author: SonataCI

.github/workflows/test.yaml

@@ -30,7 +30,6 @@ jobs:
         strategy:
             matrix:
                 php-version:
-                    - '8.0'
                     - '8.1'
                     - '8.2'
                     - '8.3'
@@ -39,30 +38,25 @@ jobs:
                 symfony-require: ['']
                 variant: [normal]
                 include:
-                    - php-version: '8.0'
+                    - php-version: '8.1'
                       dependencies: lowest
                       allowed-to-fail: false
                       variant: normal
                     - php-version: '8.3'
                       dependencies: highest
                       allowed-to-fail: false
-                      symfony-require: 5.4.*
-                      variant: symfony/symfony:"5.4.*"
-                    - php-version: '8.3'
-                      dependencies: highest
-                      allowed-to-fail: false
-                      symfony-require: 6.3.*
-                      variant: symfony/symfony:"6.3.*"
+                      symfony-require: 6.4.*
+                      variant: symfony/symfony:"6.4.*"
                     - php-version: '8.3'
                       dependencies: highest
                       allowed-to-fail: false
-                      symfony-require: 6.4.*
-                      variant: symfony/symfony:"6.4.*"
+                      symfony-require: 7.1.*
+                      variant: symfony/symfony:"7.1.*"
                     - php-version: '8.3'
                       dependencies: highest
                       allowed-to-fail: false
-                      symfony-require: 7.0.*
-                      variant: symfony/symfony:"7.0.*"
+                      symfony-require: 7.2.*
+                      variant: symfony/symfony:"7.2.*"
 
         steps:
             - name: Checkout

rector.php

@@ -19,6 +19,7 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Php70\Rector\FunctionLike\ExceptionHandlerTypehintRector;
+use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\Set\PHPUnitSetList;
@@ -31,7 +32,7 @@
     ]);
 
     $rectorConfig->sets([
-        LevelSetList::UP_TO_PHP_80,
+        LevelSetList::UP_TO_PHP_81,
         PHPUnitSetList::PHPUNIT_90,
         PHPUnitSetList::PHPUNIT_CODE_QUALITY,
     ]);
@@ -40,6 +41,7 @@
     $rectorConfig->importShortClasses(false);
     $rectorConfig->skip([
         ExceptionHandlerTypehintRector::class,
+        ReadOnlyPropertyRector::class,
         PreferPHPUnitThisCallRector::class,
         NarrowUnusedSetUpDefinedPropertyRector::class,
     ]);

tests/Functional/Frontend/ExceptionsTest.php

@@ -16,8 +16,8 @@
 use Doctrine\ORM\EntityManagerInterface;
 use Sonata\PageBundle\Tests\App\Entity\SonataPagePage;
 use Sonata\PageBundle\Tests\App\Entity\SonataPageSite;
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
-use Symfony\Component\BrowserKit\AbstractBrowser;
 use Symfony\Component\BrowserKit\Cookie;
 use Symfony\Component\HttpFoundation\Session\SessionFactoryInterface;
 use Symfony\Component\Security\Core\User\OidcUser;
@@ -97,7 +97,7 @@ private function prepareData(): void
      * Normally this would happen via an interactive login.
      * Part of this logic is also copied from AbstractBrowser::loginUser().
      */
-    private function becomeEditor(AbstractBrowser $client): void
+    private function becomeEditor(KernelBrowser $client): void
     {
         $sessionFactory = self::getContainer()->get('session.factory');
         \assert($sessionFactory instanceof SessionFactoryInterface);

tests/Functional/Frontend/PageTest.php

@@ -18,8 +18,8 @@
 use Sonata\PageBundle\Tests\App\Entity\SonataPageBlock;
 use Sonata\PageBundle\Tests\App\Entity\SonataPagePage;
 use Sonata\PageBundle\Tests\App\Entity\SonataPageSite;
+use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
-use Symfony\Component\BrowserKit\AbstractBrowser;
 use Symfony\Component\BrowserKit\Cookie;
 use Symfony\Component\HttpFoundation\Session\SessionFactoryInterface;
 
@@ -366,7 +366,7 @@ private function prepareGlobalPageData(): void
      * Normally this would happen via an interactive login.
      * Part of this logic is also copied from AbstractBrowser::loginUser().
      */
-    private function becomeEditor(AbstractBrowser $client): void
+    private function becomeEditor(KernelBrowser $client): void
     {
         $sessionFactory = self::getContainer()->get('session.factory');
         \assert($sessionFactory instanceof SessionFactoryInterface);