[Mellanox] Add PCI ID detection for the mlnx-fw-upgrade.sh script (#24244)

- Why I did it
Related to: #23505

Add support for detecting and storing device PCI address in asic_detect.sh:

Add -p option to return PCI address (e.g., "06:00.0")
Store PCI ID alongside device type for synchronization
Re-detect if either cache file is missing
Simplify firmware upgrade flow in mlnx-fw-upgrade.j2:

Use asic_detect.sh -p to get PCI ID directly for MST device
Simplify GetSPCMstDevice to directly use detected PCI address

- How I did it
Do not stop MST drivers from syncd.sh

- How to verify it
Run sonic-mgmt tests

Author: oleksandrivantsiv

files/scripts/syncd.sh

@@ -136,7 +136,6 @@ function stopplatform2() {
     if [[ x"$WARM_BOOT" != x"true" ]]; then
         if [ x$sonic_asic_platform == x'mellanox' ]; then
             /etc/init.d/sxdkernel stop
-            /usr/bin/mst stop
         elif [ x"$sonic_asic_platform" == x"nvidia-bluefield" ]; then
             /usr/bin/bfnet.sh stop
         fi

platform/mellanox/asic_detect/asic_detect.sh

@@ -19,9 +19,25 @@
 
 SUCCESS_CODE=0
 RC=-1
+RETURN_PCI_ID=false
 
-if [[ -f "/usr/bin/asic_detect/asic_type" ]]; then
-    cat /usr/bin/asic_detect/asic_type
+# Parse command line arguments
+while getopts "p" opt; do
+    case $opt in
+        p)
+            RETURN_PCI_ID=true
+            ;;
+        *)
+            ;;
+    esac
+done
+
+if [[ -f "/usr/bin/asic_detect/asic_type" ]] && [[ -f "/usr/bin/asic_detect/asic_pci_id" ]]; then
+    if [[ "$RETURN_PCI_ID" == true ]]; then
+        cat /usr/bin/asic_detect/asic_pci_id
+    else
+        cat /usr/bin/asic_detect/asic_type
+    fi
     exit $SUCCESS_CODE
 fi
 
@@ -37,6 +53,7 @@ declare -A DEVICE_DICT=(
 TYPE_UNKNOWN="unknown"
 VENDOR_ID="15b3"
 DEVICE_TYPE=$TYPE_UNKNOWN
+DEVICE_PCI_ID=""
 
 # bf3 should be the last device in the list
 DEVICE_ORDER=("cb84" "cf6c" "cf70" "cf80" "cf82" "a2dc")
@@ -46,12 +63,21 @@ if [[ -n "$lspci_output" ]]; then
     for key in "${DEVICE_ORDER[@]}"; do
         if echo "$lspci_output" | grep "$VENDOR_ID:$key" &>/dev/null; then
             DEVICE_TYPE="${DEVICE_DICT[$key]}"
+            DEVICE_PCI_ID=$(echo "$lspci_output" | grep "$VENDOR_ID:$key" | awk '{print $1}')
             RC=$SUCCESS_CODE
             break
         fi
     done
     if [[ -n "$DEVICE_TYPE" ]]; then
-        echo "$DEVICE_TYPE" | tee >( [[ "$DEVICE_TYPE" != "$TYPE_UNKNOWN" ]] && cat > /usr/bin/asic_detect/asic_type )
+        if [[ "$RETURN_PCI_ID" == true ]]; then
+            echo "$DEVICE_PCI_ID"
+        else
+            echo "$DEVICE_TYPE"
+        fi
+        if [[ "$DEVICE_TYPE" != "$TYPE_UNKNOWN" ]] && [[ -n "$DEVICE_PCI_ID" ]]; then
+            echo "$DEVICE_TYPE" > /usr/bin/asic_detect/asic_type
+            echo "$DEVICE_PCI_ID" > /usr/bin/asic_detect/asic_pci_id
+        fi
     fi
     exit $RC
 fi

platform/mellanox/mlnx-fw-upgrade.j2

@@ -90,9 +90,9 @@ function PrintHelp() {
     echo "Examples:"
     echo "  ./${SCRIPT_NAME} --verbose"
     echo "  ./${SCRIPT_NAME} --upgrade"
-    echo "  ./${SCRIPT_NAME} --no-mst"
 {% if sonic_asic_platform == "nvidia-bluefield" %}
     echo "  ./${SCRIPT_NAME} --reset"
+    echo "  ./${SCRIPT_NAME} --no-mst"
 {% endif %}
     echo "  ./${SCRIPT_NAME} --help"
     echo
@@ -239,10 +239,6 @@ function WaitForDevice() {
     if [[ "${NO_MST}" != "${YES_PARAM}" ]]; then
         LogInfo "Restarting MST device"
         /usr/bin/mst restart --with_i2cdev
-        ERROR_CODE="$?"
-        if [[ "${ERROR_CODE}" != "${EXIT_SUCCESS}" ]]; then
-            ExitFailure "MST device restart failed with error: ${ERROR_CODE}"
-        fi
     fi
 
     while : ; do
@@ -266,15 +262,11 @@ function WaitForDevice() {
 }
 
 function GetSPCMstDevice() {
-    local _DEVICE_TYPE=$(GetMstDeviceType)
-    local _MST_DEVICE=$(${QUERY_XML} | xmlstarlet sel -t -m "//Device[contains(@type,'${_DEVICE_TYPE}')]" -v @pciName | head -n 1)
-
-    if [[ ! -c "${_MST_DEVICE}" ]]; then
-        echo "${UNKN_MST}"
-    else
-        echo "${_MST_DEVICE}"
+    local -r _ASIC_PCI_ID="$(/usr/bin/asic_detect/asic_detect.sh -p)"
+    if [[ "${_ASIC_PCI_ID}" = "${UNKN_PCI_ID}" ]]; then
+        ExitFailure "failed to detect ASIC PCI ID"
     fi
-
+    echo "${_ASIC_PCI_ID}"
     exit "${EXIT_SUCCESS}"
 }