[Bookworm] Fix timezone propagation to containers (#21079)

- Why I did it
Fix #20925

Not cherry-pickable to 202405, will raise a separate PR

- How I did it
Mount /etc/localtime on containers and remove /etc/timezone dependency

- How to verify it
root@sonic:/home/admin# zdump /etc/localtime
/etc/localtime  Fri Dec  6 23:24:03 2024 IST

root@sonic:/home/admin# docker exec swss zdump /etc/localtime
/etc/localtime  Fri Dec  6 23:24:12 2024 IST
Verify swss.rec/sairedis.rec and syslog are following same time

Signed-off-by: Vivek <[email protected]>

Author: vivekrnv

dockers/docker-database/docker-database-init.sh

@@ -133,10 +133,6 @@ do
     chown -R redis:redis /var/lib/$inst
 done
 
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime
-
 chown -R redis:redis $REDIS_DIR
 REDIS_BMP_DIR="/var/lib/redis_bmp"
 chown -R redis:redis $REDIS_BMP_DIR

dockers/docker-dhcp-relay/start.sh

@@ -10,10 +10,6 @@ then
     ${CTR_SCRIPT} -f dhcp_relay -o ${RUNTIME_OWNER} -v ${IMAGE_VERSION}
 fi
 
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime
-
 # If our supervisor config has entries in the "dhcp-relay" group...
 if [ $(supervisorctl status | grep -c "^dhcp-relay:") -gt 0 ]; then
     # Wait for all interfaces to come up and be assigned IPv4 addresses before

dockers/docker-dhcp-server/start.sh

@@ -13,7 +13,3 @@ if test -f ${CTR_SCRIPT}
 then
     ${CTR_SCRIPT} -f dhcp_server -o ${RUNTIME_OWNER} -v ${IMAGE_VERSION}
 fi
-
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime

dockers/docker-eventd/start.sh

@@ -4,6 +4,3 @@ if [ "${RUNTIME_OWNER}" == "" ]; then
     RUNTIME_OWNER="kube"
 fi
 
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime

dockers/docker-fpm-frr/docker_init.sh

@@ -108,8 +108,4 @@ chmod 0755 /usr/sbin/bgp-unisolate
 mkdir -p /var/sonic
 echo "# Config files managed by sonic-config-engine" > /var/sonic/config_status
 
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime
-
 exec /usr/local/bin/supervisord

dockers/docker-iccpd/start.sh

@@ -11,6 +11,3 @@ sonic-cfggen -d -t /usr/share/sonic/templates/iccpd.j2 > $ICCPD_CONF_PATH/iccpd.
 mkdir -p /var/sonic
 echo "# Config files managed by sonic-config-engine" > /var/sonic/config_status
 
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime

dockers/docker-lldp/start.sh

@@ -23,7 +23,3 @@ mkdir -p /var/sonic
 echo "# Config files managed by sonic-config-engine" > /var/sonic/config_status
 
 rm -f /var/run/lldpd.socket
-
-TZ=$(cat /etc/timezone)
-rm -rf /etc/localtime
-ln -sf /usr/share/zoneinfo/$TZ /etc/localtime

dockers/docker-macsec/Dockerfile.j2

@@ -21,7 +21,6 @@ RUN apt-get clean -y      && \
     apt-get autoremove -y && \
     rm -rf /debs
 
-COPY ["start.sh", "/usr/bin/"]
 COPY ["supervisord.conf", "/etc/supervisor/conf.d/"]
 COPY ["files/supervisor-proc-exit-listener", "/usr/bin"]
 COPY ["critical_processes", "/etc/supervisor"]

dockers/docker-macsec/start.sh

@@ -28,17 +28,6 @@ stdout_logfile=syslog
 stderr_logfile=syslog
 dependent_startup=true
 
-[program:start]
-command=/usr/bin/start.sh
-priority=2
-autostart=false
-autorestart=false
-startsecs=0
-stdout_logfile=syslog
-stderr_logfile=syslog
-dependent_startup=true
-dependent_startup_wait_for=rsyslogd:running
-
 [program:macsecmgrd]
 command=/usr/bin/macsecmgrd
 priority=2