rsyslog-config.sh: not setting docker0_ip before DEVICE_METADATA.localhost.platform is set

[huanlev]

Hello,

What are the reasons/justifications for rsyslog-config.sh uses DEVICE_METADATA.localhost.platform here?

Some log messages forwarded to docker0 IP address from the container were lost after:

1. onie boot
2. sonic-cfggen to apply config
3. sonic-db-cli CONFIG_DB SET CONFIG_DB_INITIALIZED "1"

Could this be replaced by python3 - "from sonic_py_common import device_info; print(device_info.get_platform())?
Appreciate your response. And please let me know if an issue/PR is needed.

Best,
Huan

cisco@sonic:~$ time sonic-db-cli CONFIG_DB hget "DEVICE_METADATA|localhost" "platform"
x86_64-8800_rp_o-r0

real    0m0.008s
user    0m0.000s
sys     0m0.007s
cisco@sonic:~$ time python3 -c "from sonic_py_common import device_info as di; print(di.get_platform())"
x86_64-8800_rp_o-r0

real    0m0.081s
user    0m0.069s
sys     0m0.008s
cisco@sonic:~$ time sonic-cfggen -H -v "DEVICE_METADATA.localhost.platform"
x86_64-8800_rp_o-r0

real    0m0.181s
user    0m0.147s
sys     0m0.024s