Bug:[Chassis] Tab key does not complete the sonic cli command

[mannytaheri]

Is it platform specific

generic

Importance or Severity

Critical

Description of the bug

Tab key does not complete the sonic cli command using master image

For example:
board201:$ show in should complete to:
board201:$ show interfaces

Steps to Reproduce

Use a portion of a sonic cli command and press the tab key.

Actual Behavior and Expected Behavior

Actual:
show int does not complete to show interfaces
Expected:
show int should complete to show interfaces

Relevant log output

Output of show version, show techsupport

Latest master image

Attach files (if any)

No response

[zjswhhh]

Can it be due to the python click module upgrade with Trixie?

@saiarcot895 - can you please take a look?

[anders-nexthop]

Looks like this is due to the upgrade to Click version 8 (from the upgrade notes):

Redesign the shell completion system. [#1484](https://github.com/pallets/click/issues/1484), [#1622](https://github.com/pallets/click/pull/1622)

Support Bash >= 4.4, Zsh, and Fish, with the ability for extensions to add support for other shells.

Allow commands, groups, parameters, and types to override their completions suggestions.

Groups complete the names commands were registered with, which can differ from the name they were created with.

The autocompletion parameter for options and arguments is renamed to shell_complete. The function must take ctx, param, incomplete, must do matching rather than return all values, and must return a list of strings or a list of CompletionItem. The old name and behavior is deprecated and will be removed in 8.1.

The env var values used to start completion have changed order. The shell now comes first, such as {shell}_source rather than source_{shell}, and is always required.

This is an easy fix, we just need to go through all the places where we are we are using Click completion env vars and fix the names to match the new schema, like this:

diff --git a/sonic-utilities-data/bash_completion.d/acl-loader b/sonic-utilities-data/bash_completion.d/acl-loader
index 98be34b1..88cc30db 100644
--- a/sonic-utilities-data/bash_completion.d/acl-loader
+++ b/sonic-utilities-data/bash_completion.d/acl-loader
@@ -1,7 +1,7 @@
 _acl_loader_completion() {
     COMPREPLY=( $( env COMP_WORDS="${COMP_WORDS[*]}" \
                    COMP_CWORD=$COMP_CWORD \
-                   _ACL_LOADER_COMPLETE=complete $1 ) )
+                   _ACL_LOADER_COMPLETE=bash_complete $1 ) )
     return 1
 }

@zjswhhh can you assign this one to me please?

[saiarcot895]

FYI, there's an initial PR at sonic-net/sonic-utilities#4163 for this. I've updated the code locally to make it autogenerated, but haven't pushed it yet.

[saiarcot895]

Duplicate of #24594

[anders-nexthop]

Ok great, it looks like @saiarcot895 is already on it.