permit_root_login is an enum not a boolean

Author: bhouse-nexthop

scripts/hostcfgd

@@ -1126,7 +1126,7 @@ class SshServer(object):
                 if key == "inactivity_timeout":
                     # translate min to sec.
                     value = int(value) * 60
-                elif key in [ "permit_root_login", "password_authentication" ]:
+                elif key == "password_authentication":
                     # translate boolean to yes/no
                     if isinstance(value, str):
                         value = "no" if value.lower() in [ "false" ] else "yes"

tests/hostcfgd/test_ssh_server_vectors.py

@@ -214,7 +214,7 @@
                         "ports": "22",
                         "inactivity_timeout": "15",
                         "max_sessions": "0",
-                        "permit_root_login": "false"
+                        "permit_root_login": "no"
                     }
                 },
                 "DEVICE_METADATA": {