Skip to content

Commit 08e5a32

Browse files
authored
Update LPMODE_SKIP_LIST to use Vendor PN instead (#20826)
Description of PR Summary: Fixes # #20597 Change introduced here: sonic-net/sonic-platform-common#590 This pull request updates the logic for skipping certain transceivers in the LPMODE test due to known issues. The main change is to use the transceiver model instead of the host_electrical_interface for more accurate identification of devices to skip. Improvements to transceiver skipping logic: Updated the LPMODE_SKIP_LIST in test_sfp.py to specify transceivers by model instead of host_electrical_interface, listing specific Cloud Light models to skip. Modified the is_xcvr_support_lpmode method to check the model field when determining whether to skip a transceiver, and improved the log message to include both manufacturer and model. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? How did you do it? Collect Vendor PN instead of host_electrical_interface How did you verify/test it? Tested on Cisco 8800 devices, where we saw the issue originally =========================== short test summary info ============================ SKIPPED [1] platform_tests/api/test_sfp.py:825: skipping for supervisor node ============= 2 passed, 1 skipped, 4 warnings in 994.55s (0:16:34) ============= signed-off-by: [email protected]
1 parent 27a57e0 commit 08e5a32

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

tests/platform_tests/api/test_sfp.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,11 @@ class TestSfpApi(PlatformApiTestBase):
271271

272272
# xcvr to be skipped for lpmode test due to known issue
273273
LPMODE_SKIP_LIST = [
274-
{'manufacturer': 'Cloud Light', 'host_electrical_interface': '400GAUI-8 C2M (Annex 120E)'},
274+
{'manufacturer': 'Cloud Light', 'model': '7123-G37-01'},
275+
{'manufacturer': 'Cloud Light', 'model': '7123-G37-02'},
276+
{'manufacturer': 'Cloud Light', 'model': '7123-G37-05'},
277+
{'manufacturer': 'Cloud Light', 'model': '7123-G37-0X'},
278+
{'manufacturer': 'Cloud Light', 'model': '7123-G37-10'},
275279
]
276280

277281
# Keys supported for Amphenol 800G Backplane cartridge.
@@ -360,9 +364,9 @@ def is_xcvr_support_lpmode(self, xcvr_info_dict):
360364
# Temporarily add this logic to skip lpmode test for some transceivers with known issue
361365
for xcvr_to_skip in self.LPMODE_SKIP_LIST:
362366
if (xcvr_info_dict["manufacturer"].strip() == xcvr_to_skip["manufacturer"] and
363-
xcvr_info_dict["host_electrical_interface"].strip() == xcvr_to_skip["host_electrical_interface"]):
364-
logger.info("Temporarily skipping {} due to known issue".format(
365-
xcvr_info_dict["manufacturer"]))
367+
xcvr_info_dict["model"].strip() == xcvr_to_skip["model"]):
368+
logger.info("Temporarily skipping {} - {} due to known issue".format(
369+
xcvr_info_dict["manufacturer"], xcvr_info_dict["model"]))
366370
return False
367371

368372
return True

0 commit comments

Comments
 (0)