[action] [PR:21102] Require swap syncd before running disable VOQ watchdog #21302
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR? How did you do it? How did you verify/test it? Validated on master branch qos/test_tunnel_qos_remap.py on hash 20aae03 without extra parameters (for example, without "--qos_swap_syncd=False" or disabling loganalyzer) Validated on 202411 active watermark test case passes =============================================== 10 passed, 7 skipped, 851 warnings in 8220.27s (2:17:00) ============= sonic-mgmt$ git log -n 1 commit 20aae03 (HEAD -> voq_wd_syncd_swap_issue_master, origin/voq_wd_syncd_swap_issue_master) Author: Randall Pittman <[email protected]> Date: Wed Nov 5 23:25:14 2025 +0000 Require swap_syncd before setup_module.
13 tasks
Collaborator
Author
|
Original PR: #21102 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes issue with order of operations when syncd container is dynamically swapped during test_tunnel_qos_remap.py with respect to the VOQ Watchdog disabler.
The VOQ watchdog fixture runs first because it has no dependency on the syncd swap. Thus the WD is temporarily disabled, but then the syncd-swap (config reload) reload re-enables it.
Fix by requiring the syncd_swap to be performed before the disable_voq_watchdog_dualtor fixture runs.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation