Skip to content

Conversation

@bingwang-ms
Copy link
Collaborator

@bingwang-ms bingwang-ms commented Nov 14, 2025

Description of PR

Summary:
This PR is to enable retry for some EOS command.
Retry is enabled for below functions for now as we saw connection error frequently on these commands, and the failure will leave testbed in unhealthy state.

  • no_shutdown
  • shutdown
  • start_bgpd
  • no_shutdown_bgp
  • no_shutdown_bgp_neighbors

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202503

Approach

What is the motivation for this PR?

This PR is to enable retry for some EOS command.

How did you do it?

Leverage Python module retry to rerun the command if there is exception.

How did you verify/test it?

The change is verified by running on a physical testbed. Retry is working if connection issue happened.

22:18:47 api.__retry_internal                     L0040 WARNING| run module eos_config failed, Ansible Results =>
failed = True
module_stdout = 
module_stderr = command timeout triggered, timeout value is 60 secs.
See the timeout setting options in the Network Debug and Troubleshooting Guide.
msg = MODULE FAILURE
See stdout/stderr for the exact error
_ansible_no_log = None
changed = False
stdout =
stderr =
, retrying in 5 seconds...
22:19:53 api.__retry_internal                     L0040 WARNING| run module eos_config failed, Ansible Results =>
failed = True
module_stdout = 
module_stderr = command timeout triggered, timeout value is 60 secs.
See the timeout setting options in the Network Debug and Troubleshooting Guide.
msg = MODULE FAILURE
See stdout/stderr for the exact error
_ansible_no_log = None
changed = False
stdout =
stderr =
, retrying in 5 seconds...
22:20:58 __init__.pytest_runtest_call             L0040 ERROR  | Traceback (most recent call last):

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms force-pushed the enable_retry_eos_command branch from 2c7650c to 9eb27bd Compare November 14, 2025 22:41
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Collaborator Author

@wangxin Could you help review? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants