Refactor xcvrd common functions and improve logging (#654)

- Refactor common xcvrd functions into shared utilities
- Move functions from xcvrd.py to xcvrd_utilities/xcvrd_shared_utilities.py
- Add thread identifier to logging for better debugging
- Fix test imports after refactoring
- Add common utility functions for better code organization
- Improve logging consistency across xcvrd components

Author: bobby-nexthop

sonic-xcvrd/tests/test_xcvrd.py

@@ -22,6 +22,7 @@
     from xcvrd.xcvrd_utilities import sfp_status_helper
     from xcvrd.xcvrd_utilities.xcvr_table_helper import *
     from xcvrd.xcvrd_utilities import port_event_helper
+    from xcvrd.xcvrd_utilities import common
     from xcvrd.dom.utilities.dom_sensor.db_utils import DOMDBUtils
     from xcvrd.dom.utilities.vdm.utils import VDMUtils
     from xcvrd.dom.utilities.vdm.db_utils import VDMDBUtils
@@ -129,7 +130,7 @@ def is_port_in_cmis_initialization_process(self, logical_port_name):
             self.log_warning("Got invalid asic index for {} while checking cmis init status".format(logical_port_name))
             return False
 
-        cmis_state = xcvrd.get_cmis_state_from_state_db(logical_port_name, self.xcvr_table_helper.get_status_sw_tbl(asic_index))
+        cmis_state = common.get_cmis_state_from_state_db(logical_port_name, self.xcvr_table_helper.get_status_sw_tbl(asic_index))
         if cmis_state not in xcvrd.CMIS_TERMINAL_STATES:
             return True
         else:
@@ -142,19 +143,19 @@ def is_port_dom_monitoring_disabled(self, logical_port_name):
     # Update port sfp firmware info in db
     def post_port_sfp_firmware_info_to_db(self, logical_port_name, port_mapping, table,
                                 stop_event=threading.Event(), firmware_info_cache=None):
-        for physical_port, physical_port_name in xcvrd.get_physical_port_name_dict(logical_port_name, port_mapping).items():
+        for physical_port, physical_port_name in common.get_physical_port_name_dict(logical_port_name, port_mapping).items():
             if stop_event.is_set():
                 break
 
-            if not xcvrd._wrapper_get_presence(physical_port):
+            if not common._wrapper_get_presence(physical_port):
                 continue
 
             try:
                 if firmware_info_cache is not None and physical_port in firmware_info_cache:
                     # If cache is enabled and firmware information is in cache, just read from cache, no need read from EEPROM
                     transceiver_firmware_info_dict = firmware_info_cache[physical_port]
                 else:
-                    transceiver_firmware_info_dict = xcvrd._wrapper_get_transceiver_firmware_info(physical_port)
+                    transceiver_firmware_info_dict = common._wrapper_get_transceiver_firmware_info(physical_port)
                     if firmware_info_cache is not None:
                         # If cache is enabled, put firmware information to cache
                         firmware_info_cache[physical_port] = transceiver_firmware_info_dict
@@ -176,21 +177,21 @@ def post_port_sfp_firmware_info_to_db(self, logical_port_name, port_mapping, tab
 
     # Update port pm info in db
     def post_port_pm_info_to_db(self, logical_port_name, port_mapping, table, stop_event=threading.Event(), pm_info_cache=None):
-        for physical_port, physical_port_name in xcvrd.get_physical_port_name_dict(logical_port_name, port_mapping).items():
+        for physical_port, physical_port_name in common.get_physical_port_name_dict(logical_port_name, port_mapping).items():
             if stop_event.is_set():
                 break
 
-            if not xcvrd._wrapper_get_presence(physical_port):
+            if not common._wrapper_get_presence(physical_port):
                 continue
 
-            if xcvrd._wrapper_is_flat_memory(physical_port) == True:
+            if common._wrapper_is_flat_memory(physical_port) == True:
                 continue
 
             if pm_info_cache is not None and physical_port in pm_info_cache:
                 # If cache is enabled and pm info is in cache, just read from cache, no need read from EEPROM
                 pm_info_dict = pm_info_cache[physical_port]
             else:
-                pm_info_dict = xcvrd._wrapper_get_transceiver_pm(physical_port)
+                pm_info_dict = common._wrapper_get_transceiver_pm(physical_port)
                 if pm_info_cache is not None:
                     # If cache is enabled, put dom information to cache
                     pm_info_cache[physical_port] = pm_info_dict
@@ -268,7 +269,7 @@ def task_worker(self):
                     continue
 
                 if not sfp_status_helper.detect_port_in_error_status(logical_port_name, self.xcvr_table_helper.get_status_sw_tbl(asic_index)):
-                    if not xcvrd._wrapper_get_presence(physical_port):
+                    if not common._wrapper_get_presence(physical_port):
                         continue
 
                     try:
@@ -345,7 +346,7 @@ def run(self):
             self.task_worker()
         except Exception as e:
             self.log_error("Exception occured at {} thread due to {}".format(threading.current_thread().getName(), repr(e)))
-            xcvrd.log_exception_traceback()
+            common.log_exception_traceback()
             self.exc = e
             self.main_thread_stop_event.set()
 
@@ -440,7 +441,7 @@ def on_remove_logical_port(self, port_change_event):
         # To avoid race condition, remove the entry TRANSCEIVER_FIRMWARE_INFO, TRANSCEIVER_DOM_SENSOR, TRANSCEIVER_PM and HW section of TRANSCEIVER_STATUS table.
         # This thread only updates TRANSCEIVER_FIRMWARE_INFO, TRANSCEIVER_DOM_SENSOR, TRANSCEIVER_PM and HW section of TRANSCEIVER_STATUS table,
         # so we don't have to remove entries from TRANSCEIVER_INFO, TRANSCEIVER_DOM_THRESHOLD and VDM threshold value tables.
-        xcvrd.del_port_sfp_dom_info_from_db(port_change_event.port_name,
+        common.del_port_sfp_dom_info_from_db(port_change_event.port_name,
                                       self.port_mapping,
                                       [self.xcvr_table_helper.get_dom_tbl(port_change_event.asic_id),
                                       self.xcvr_table_helper.get_dom_flag_tbl(port_change_event.asic_id),