From 7a48ee499c39b9c92ef054aad2b7d76c34e2b956 Mon Sep 17 00:00:00 2001 From: "Brad House (nexthop)" Date: Wed, 9 Apr 2025 09:00:37 -0400 Subject: [PATCH 1/2] dot3 Stats collection RFC1284 defines dot3 stats that most switch vendors support. This RFC was superceded by RFC3635 which includes 64bit "HC" counters. We need to collect these statistics for use by sonic_snmpagent. Signed-off-by: Brad House --- orchagent/portsorch.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp index 1fb694d79e..e2fa9e05ee 100644 --- a/orchagent/portsorch.cpp +++ b/orchagent/portsorch.cpp @@ -307,6 +307,19 @@ const vector port_stat_ids = SAI_PORT_STAT_TRIM_PACKETS, SAI_PORT_STAT_DROPPED_TRIM_PACKETS, SAI_PORT_STAT_TX_TRIM_PACKETS + SAI_PORT_STAT_DOT3_STATS_ALIGNMENT_ERRORS, + SAI_PORT_STAT_DOT3_STATS_FCS_ERRORS, + SAI_PORT_STAT_DOT3_STATS_SINGLE_COLLISION_FRAMES, + SAI_PORT_STAT_DOT3_STATS_MULTIPLE_COLLISION_FRAMES, + SAI_PORT_STAT_DOT3_STATS_SQE_TEST_ERRORS, + SAI_PORT_STAT_DOT3_STATS_DEFERRED_TRANSMISSIONS, + SAI_PORT_STAT_DOT3_STATS_LATE_COLLISIONS, + SAI_PORT_STAT_DOT3_STATS_EXCESSIVE_COLLISIONS, + SAI_PORT_STAT_DOT3_STATS_INTERNAL_MAC_TRANSMIT_ERRORS, + SAI_PORT_STAT_DOT3_STATS_CARRIER_SENSE_ERRORS, + SAI_PORT_STAT_DOT3_STATS_FRAME_TOO_LONGS, + SAI_PORT_STAT_DOT3_STATS_INTERNAL_MAC_RECEIVE_ERRORS, + SAI_PORT_STAT_DOT3_STATS_SYMBOL_ERRORS }; const vector gbport_stat_ids = From 490bf4b777927b44bc95f4528ea1afffb67941df Mon Sep 17 00:00:00 2001 From: Brad House Date: Fri, 24 Oct 2025 10:44:45 -0400 Subject: [PATCH 2/2] fix bad merge conflict resolution --- orchagent/portsorch.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp index e2fa9e05ee..36f3a18ad4 100644 --- a/orchagent/portsorch.cpp +++ b/orchagent/portsorch.cpp @@ -306,7 +306,7 @@ const vector port_stat_ids = SAI_PORT_STAT_IF_IN_FEC_CORRECTED_BITS, SAI_PORT_STAT_TRIM_PACKETS, SAI_PORT_STAT_DROPPED_TRIM_PACKETS, - SAI_PORT_STAT_TX_TRIM_PACKETS + SAI_PORT_STAT_TX_TRIM_PACKETS, SAI_PORT_STAT_DOT3_STATS_ALIGNMENT_ERRORS, SAI_PORT_STAT_DOT3_STATS_FCS_ERRORS, SAI_PORT_STAT_DOT3_STATS_SINGLE_COLLISION_FRAMES,