Skip to content

Commit 396c61a

Browse files
authored
Merge pull request #2752 from ethancrawford/fix_empty_rings
2 parents e4ae9ac + 4099a5c commit 396c61a

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

app/server/ruby/core.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -904,8 +904,9 @@ def map_index(idx)
904904

905905
class RingVector < SPVector
906906
def map_index(idx)
907-
idx = idx % size
908-
return idx
907+
return idx unless size.positive?
908+
909+
idx % size
909910
end
910911

911912
def ___sp_vector_name

app/server/ruby/test/test_ring.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,5 +202,9 @@ def test_ramp_tick
202202
assert_equal(3, r.tick)
203203
assert_equal(3, r.tick)
204204
end
205+
206+
def test_index_empty_ring
207+
assert_nil(ring()[0])
208+
end
205209
end
206210
end

0 commit comments

Comments
 (0)