GUI - clean up server sync logic on boot

Author: samaaron

app/gui/qt/mainwindow.cpp

@@ -441,7 +441,7 @@ MainWindow::MainWindow(QApplication &app, bool i18n, QSplashScreen* splash)
 
   connect(&app, SIGNAL( aboutToQuit() ), this, SLOT( onExitCleanup() ) );
 
-  waitForServiceSync();
+
 
   initPrefsWindow();
 
@@ -462,6 +462,10 @@ MainWindow::MainWindow(QApplication &app, bool i18n, QSplashScreen* splash)
 
   focusMode = false;
 
+  // Wait to hear back from the server before continuing
+  waitForServiceSync();
+  serverStarted();
+
   updateDarkMode();
   initDocsWindow();
   updateFullScreenMode();
@@ -736,12 +740,8 @@ void MainWindow::waitForServiceSync() {
     }
   }
   if (!sonicPiServer->isServerStarted()) {
-
-    if (!startup_error_reported) {
       std::cout << "[GUI] - critical error!" << std::endl;
       invokeStartupError("Critical server error!");
-    }
-    return;
   }
 
   std::cout << "[GUI] - server connection established" << std::endl;

app/gui/qt/oschandler.cpp

@@ -168,9 +168,6 @@ void OscHandler::oscMessage(std::vector<char> buffer){
       else if (msg->match("/ack")) {
         std::string id;
         if (msg->arg().popStr(id).isOkNoMoreArgs()) {
-          if(!server_started) {
-            QMetaObject::invokeMethod(window, "serverStarted", Qt::QueuedConnection);
-          }
           server_started = true;
 
         } else