File tree Expand file tree Collapse file tree 2 files changed +13
-3
lines changed Expand file tree Collapse file tree 2 files changed +13
-3
lines changed Original file line number Diff line number Diff line change 1+ Improved error message when building without a Windows SDK installed.
Original file line number Diff line number Diff line change 108108
109109 <!-- The minimum allowed SDK version to use for building -->
110110 <DefaultWindowsSDKVersion >10.0.10586.0</DefaultWindowsSDKVersion >
111- <DefaultWindowsSDKVersion Condition =" $([System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))" >$(_RegistryVersion)</DefaultWindowsSDKVersion >
111+ <DefaultWindowsSDKVersion Condition =" $(_RegistryVersion) != '' and $( [System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))" >$(_RegistryVersion)</DefaultWindowsSDKVersion >
112112 </PropertyGroup >
113-
113+
114+ <Target Name =" _CheckWindowsSDKFound" BeforeTargets =" _CheckWindowsSDKInstalled" Condition =" $(_RegistryVersion) == ''" >
115+ <PropertyGroup >
116+ <_Message >Failed to locate a Windows SDK installation.</_Message >
117+ <_Message >$(_Message) If the build fails, please use the Visual Studio Installer to install the Windows SDK.</_Message >
118+ <_Message >$(_Message) (Ignore the version number specified in the error message and select the latest.)</_Message >
119+ </PropertyGroup >
120+ <Warning Text =" $(_Message)" />
121+ </Target >
122+
114123 <PropertyGroup Condition =" $(WindowsTargetPlatformVersion) == ''" >
115124 <WindowsTargetPlatformVersion >$(DefaultWindowsSDKVersion)</WindowsTargetPlatformVersion >
116125 </PropertyGroup >
175184 <ReleaseLevelNumber Condition =" $(_ReleaseLevel) == 'b'" >11</ReleaseLevelNumber >
176185 <ReleaseLevelNumber Condition =" $(_ReleaseLevel) == 'rc'" >12</ReleaseLevelNumber >
177186 </PropertyGroup >
178-
187+
179188 <PropertyGroup >
180189 <PythonVersionNumber >$(MajorVersionNumber).$(MinorVersionNumber).$(MicroVersionNumber)</PythonVersionNumber >
181190 <PythonVersion >$(MajorVersionNumber).$(MinorVersionNumber).$(MicroVersionNumber)$(ReleaseLevelName)</PythonVersion >
You can’t perform that action at this time.
0 commit comments