feat: parse JSON additional_fields (#1)

* feat: parse additional_fields as JSON string

Allow create_issue to accept dict or JSON string. Added test and docs.

Signed-off-by: Michael Liquori <[email protected]>

Author: 4erdenko

README.md

@@ -726,7 +726,8 @@ Here's a complete example of setting up multi-user authentication with streamabl
 
 - `jira_get_issue`: Get details of a specific issue
 - `jira_search`: Search issues using JQL
-- `jira_create_issue`: Create a new issue
+- `jira_create_issue`: Create a new issue (supports `additional_fields` as a
+  dictionary or JSON string)
 - `jira_update_issue`: Update an existing issue
 - `jira_transition_issue`: Transition an issue to a new status
 - `jira_add_comment`: Add a comment to an issue

src/mcp_atlassian/servers/jira.py

@@ -650,7 +650,7 @@ async def create_issue(
         ),
     ] = None,
     additional_fields: Annotated[
-        dict[str, Any] | None,
+        dict[str, Any] | str | None,
         Field(
             description=(
                 "(Optional) Dictionary of additional fields to set. Examples:\n"
@@ -674,7 +674,7 @@ async def create_issue(
         assignee: Assignee's user identifier (string): Email, display name, or account ID (e.g., '[email protected]', 'John Doe', 'accountid:...').
         description: Issue description.
         components: Comma-separated list of component names.
-        additional_fields: Dictionary of additional fields.
+        additional_fields: Dictionary or JSON string of additional fields.
 
     Returns:
         JSON string representing the created issue object.
@@ -691,9 +691,22 @@ async def create_issue(
         ]
 
     # Use additional_fields directly as dict
-    extra_fields = additional_fields or {}
-    if not isinstance(extra_fields, dict):
-        raise ValueError("additional_fields must be a dictionary.")
+    # Accept either dict or JSON string for additional fields
+    if additional_fields is None:
+        extra_fields: dict[str, Any] = {}
+    elif isinstance(additional_fields, dict):
+        extra_fields = additional_fields
+    elif isinstance(additional_fields, str):
+        try:
+            extra_fields = json.loads(additional_fields)
+            if not isinstance(extra_fields, dict):
+                raise ValueError(
+                    "Parsed additional_fields is not a JSON object (dict)."
+                )
+        except json.JSONDecodeError as e:
+            raise ValueError(f"additional_fields is not valid JSON: {e}") from e
+    else:
+        raise ValueError("additional_fields must be a dictionary or JSON string.")
 
     issue = jira.create_issue(
         project_key=project_key,

tests/unit/servers/test_jira_server.py

@@ -503,6 +503,31 @@ async def test_create_issue(jira_client, mock_jira_fetcher):
     )
 
 
+@pytest.mark.anyio
+async def test_create_issue_accepts_json_string(jira_client, mock_jira_fetcher):
+    """Ensure additional_fields can be a JSON string."""
+    payload = {
+        "project_key": "TEST",
+        "summary": "JSON Issue",
+        "issue_type": "Task",
+        "additional_fields": '{"labels": ["ai", "test"]}',
+    }
+    response = await jira_client.call_tool("jira_create_issue", payload)
+    assert response
+    data = json.loads(response[0].text)
+    assert data["message"] == "Issue created successfully"
+    assert "issue" in data
+    mock_jira_fetcher.create_issue.assert_called_with(
+        project_key="TEST",
+        summary="JSON Issue",
+        issue_type="Task",
+        description=None,
+        assignee=None,
+        components=None,
+        labels=["ai", "test"],
+    )
+
+
 @pytest.mark.anyio
 async def test_batch_create_issues(jira_client, mock_jira_fetcher):
     """Test batch creation of Jira issues."""