Skip to content

Commit 1910fc8

Browse files
authored
Add check (#1342)
* Add check * Fix test
1 parent cb49544 commit 1910fc8

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

pallets/demeter-farming-platform/src/lib.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -720,6 +720,7 @@ pub mod pallet {
720720

721721
// Get user info
722722
let mut user_infos = <UserInfos<T>>::get(&user);
723+
let mut found = false;
723724

724725
for user_info in user_infos.iter_mut() {
725726
if user_info.pool_asset == pool_asset
@@ -741,9 +742,12 @@ pub mod pallet {
741742
)?;
742743
}
743744
user_info.pooled_tokens -= pooled_tokens;
745+
found = true;
744746
}
745747
}
746748

749+
ensure!(found, Error::<T>::InsufficientFunds);
750+
747751
// Get pool info
748752
let mut pool_infos = <Pools<T>>::get(&pool_asset, &reward_asset);
749753
for pool_info in pool_infos.iter_mut() {

pallets/demeter-farming-platform/src/tests.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1809,7 +1809,7 @@ mod tests {
18091809
RuntimeOrigin::signed(ALICE),
18101810
asset_xstusd,
18111811
asset_ceres,
1812-
asset_xstusd,
1812+
asset_ceres,
18131813
pooled_tokens,
18141814
is_farm,
18151815
));
@@ -1818,7 +1818,7 @@ mod tests {
18181818

18191819
for user_info in user_infos.iter_mut() {
18201820
if user_info.pool_asset == asset_ceres
1821-
&& user_info.reward_asset == asset_xstusd
1821+
&& user_info.reward_asset == asset_ceres
18221822
&& user_info.is_farm == is_farm
18231823
&& user_info.base_asset == asset_xstusd
18241824
{
@@ -1827,7 +1827,7 @@ mod tests {
18271827
}
18281828

18291829
pool_infos =
1830-
demeter_farming_platform::Pools::<Runtime>::get(&asset_ceres, &asset_xstusd);
1830+
demeter_farming_platform::Pools::<Runtime>::get(&asset_ceres, &asset_ceres);
18311831
for p_info in pool_infos.iter_mut() {
18321832
if p_info.is_farm == is_farm && p_info.base_asset == asset_xstusd {
18331833
assert_eq!(p_info.total_tokens_in_pool, balance!(0))

0 commit comments

Comments
 (0)