refactor: Remove unnecessary temporary variables

sorairolake · sorairolake · commit 6cc035a33be6 · 2026-03-04T06:33:56.000+09:00
diff --git a/src/kcipher2.rs b/src/kcipher2.rs
@@ -56,8 +56,8 @@ impl KCipher2Core {
 
         next_b[..10].copy_from_slice(&self.b[1..]);
 
-        let temp1 = (self.a[0] << 8) ^ consts::AMUL0[usize::try_from(self.a[0] >> 24).unwrap()];
-        next_a[4] = temp1 ^ self.a[3];
+        next_a[4] =
+            (self.a[0] << 8) ^ consts::AMUL0[usize::try_from(self.a[0] >> 24).unwrap()] ^ self.a[3];
         if matches!(mode, Mode::Init) {
             next_a[4] ^= utils::nlf(self.b[0], self.r2, self.r1, self.a[4]);
         }

Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,8 @@ impl KCipher2Core {`
`56`	`56`
`57`	`57`	`next_b[..10].copy_from_slice(&self.b[1..]);`
`58`	`58`
`59`		`- let temp1 = (self.a[0] << 8) ^ consts::AMUL0[usize::try_from(self.a[0] >> 24).unwrap()];`
`60`		`- next_a[4] = temp1 ^ self.a[3];`
	`59`	`+ next_a[4] =`
	`60`	`+ (self.a[0] << 8) ^ consts::AMUL0[usize::try_from(self.a[0] >> 24).unwrap()] ^ self.a[3];`
`61`	`61`	`if matches!(mode, Mode::Init) {`
`62`	`62`	`next_a[4] ^= utils::nlf(self.b[0], self.r2, self.r1, self.a[4]);`
`63`	`63`	`}`