Move msvcrt shenanigans out into workflow

Author: sorsarre

.github/workflows/build-windows.yml

@@ -23,7 +23,14 @@ jobs:
         tag: v1.14.0
 
     - name: Configure CMake
-      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl -GNinja
+      run: |
+           cmake\
+           -B ${{github.workspace}}/build\
+           -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}\
+           -DCMAKE_C_COMPILER=cl\
+           -DCMAKE_CXX_COMPILER=cl\
+           -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded\
+           -GNinja
 
     - name: Build with GCC
       run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}

bitreader/CMakeLists.txt

@@ -2,14 +2,6 @@ cmake_minimum_required(VERSION 3.15)
 
 set(BRCPP_SANITIZER "none" CACHE STRING "Compile with a specific Clang sanitizer (address,undefined,leak,memory,type)")
 
-function(brcpp_add_cxx_flags FLAGS)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${FLAGS}")
-endfunction()
-
-function(brcpp_add_exe_link_flags FLAGS)
-    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${FLAGS}")
-endfunction()
-
 function(brcpp_enable_sanitizer SAN)
     if (NOT SAN MATCHES "none")
         if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
@@ -28,9 +20,6 @@ if (NOT WIN32)
         add_compile_options(-Wshorten-64-to-32)
     endif()
     add_compile_options(-Wall -Wconversion -Wsign-conversion -Werror -pedantic)
-else()
-    set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
-    message(STATUS "MSVC runtime: ${CMAKE_MSVC_RUNTIME_LIBRARY}")
 endif()
 
 set(BITREADER_SOURCES