Skip to content

Commit dcced78

Browse files
committed
remove redundant calls to old test method
All calls to assertValid (from within the actual test classes) are now also performed via decorator
1 parent 697e183 commit dcced78

File tree

1 file changed

+5
-31
lines changed

1 file changed

+5
-31
lines changed

benchexec/test_core_assignment_new.py

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -317,9 +317,6 @@ class TestCpuCoresPerRun_dualCPU_HT(TestCpuCoresPerRun):
317317
# Currently, the assignment algorithm cannot do better for odd coreLimits,
318318
# but this affects only cases where physical cores are split between runs, which is not recommended anyway.
319319

320-
def test_dualCPU_HT(self):
321-
self.assertValid(16, 2, [lrange(0, 16), lrange(16, 32)])
322-
323320

324321
@expect_assignment(1, [[x] for x in [0, 5, 10, 1, 6, 11, 2, 7, 12, 3, 8, 13, 4, 9, 14]])
325322
@expect_assignment(
@@ -473,30 +470,11 @@ class TestCpuCoresPerRun_quadCPU_HT(TestCpuCoresPerRun):
473470
use_hyperthreading = True
474471
machine_definition = ([32, 4], 2)
475472

476-
def test_quadCPU_HT(self):
477-
self.assertValid(
478-
16,
479-
4,
480-
[
481-
lrange(0, 16),
482-
lrange(16, 32),
483-
lrange(32, 48),
484-
lrange(48, 64),
485-
],
486-
)
487-
488-
# Just test that no exception occurs
489-
# Commented out tests are not longer possible
490-
# self.assertValid(1, 64) - we do not divide HT siblings
491-
self.assertValid(64, 1)
492-
self.assertValid(2, 32)
493-
self.assertValid(32, 2)
494-
# self.assertValid(3, 20) - we do not divide HT siblings: 4*20 = 80
495-
self.assertValid(16, 3)
496-
self.assertValid(4, 16)
497-
self.assertValid(16, 4)
498-
# self.assertValid(5, 12) - we do not divide HT siblings: 6*12 =72
499-
self.assertValid(8, 8)
473+
# Just test that no exception occurs
474+
# Commented out tests are not longer possible
475+
# self.assertValid(1, 64) - we do not divide HT siblings
476+
# self.assertValid(3, 20) - we do not divide HT siblings: 4*20 = 80
477+
# self.assertValid(5, 12) - we do not divide HT siblings: 6*12 =72
500478

501479

502480
@expect_assignment(1, [[x] for x in [0, 2, 4, 6]])
@@ -574,10 +552,6 @@ class TestCpuCoresPerRun_quadCPU_no_ht(TestCpuCoresPerRun):
574552
use_hyperthreading = False
575553
machine_definition = ([16, 4], 2)
576554

577-
def test_quadCPU_no_ht_valid(self):
578-
self.assertValid(5, 2, [[0, 2, 4, 6, 8], [16, 18, 20, 22, 24]])
579-
self.assertValid(6, 2, [[0, 2, 4, 6, 8, 10], [16, 18, 20, 22, 24, 26]])
580-
581555

582556
@expect_assignment(1, [[x] for x in [0, 8, 2, 10, 4, 12, 6, 14]])
583557
@expect_assignment(2, [[0, 2], [8, 10], [4, 6], [12, 14]])

0 commit comments

Comments
 (0)