[TMP] Destroy old Music object before creating new one

TODO: Will become unnecessary once
pspdev/pspsdk#330 is merged.

This ensures that any de-initialization of the old Music object (e.g.
de-registering callbacks) happens before initializing the new Music
object. This is helpful for the upcoming PSP driver.

TODO: Does this break other drivers? Use the blocking API instead if
that's the case This will complicate the driver.

Author: sotpapathe

source/Core/Game.cpp

@@ -96,6 +96,9 @@ namespace SuperHaxagon {
 	}
 
 	void Game::playTitleMusic() {
+		// Destroy the current Music object before the new one is constructed.
+		_bgm.reset();
+
 		// First, try to load from the SD card if the player wants something custom
 		_bgm = _platform.loadMusic("/title", Location::USER);
 
@@ -113,7 +116,9 @@ namespace SuperHaxagon {
 		if (loadMetadata) {
 			_bgmMetadata = std::make_unique<Metadata>(_platform.openFile(base + ".txt", location));
 		}
-		
+
+		// Destroy the current Music object before the new one is constructed.
+		_bgm.reset();
 		_bgm = _platform.loadMusic(base, location);
 
 		if (_bgm) {