Skip to content

Commit 692f01d

Browse files
committed
test: change to make the test works as expected
Signed-off-by: Maximillian Arruda <[email protected]>
1 parent a195c2d commit 692f01d

File tree

1 file changed

+3
-35
lines changed

1 file changed

+3
-35
lines changed

src/test/java/br/org/soujava/pomeditor/mojo/AddDependencyMojoTest.java

Lines changed: 3 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package br.org.soujava.pomeditor.mojo;
1919

2020

21+
import br.org.soujava.pomeditor.InvalidGroupIdArtifactIdArgs;
2122
import br.org.soujava.pomeditor.api.Dependency;
2223
import org.apache.maven.plugin.MojoExecutionException;
2324
import org.apache.maven.plugin.MojoFailureException;
@@ -29,8 +30,7 @@
2930
import org.junit.jupiter.api.Test;
3031
import org.junit.jupiter.api.extension.ExtendWith;
3132
import org.junit.jupiter.params.ParameterizedTest;
32-
import org.junit.jupiter.params.provider.Arguments;
33-
import org.junit.jupiter.params.provider.MethodSource;
33+
import org.junit.jupiter.params.provider.ArgumentsSource;
3434
import org.mockito.ArgumentCaptor;
3535
import org.mockito.Captor;
3636
import org.mockito.Mock;
@@ -48,10 +48,8 @@
4848
import java.util.function.Consumer;
4949
import java.util.function.Function;
5050
import java.util.stream.Collectors;
51-
import java.util.stream.Stream;
5251

5352
import static org.assertj.core.api.Assertions.assertThat;
54-
import static org.junit.jupiter.params.provider.Arguments.arguments;
5553
import static org.mockito.ArgumentMatchers.any;
5654
import static org.mockito.ArgumentMatchers.anyString;
5755
import static org.mockito.Mockito.atLeastOnce;
@@ -84,7 +82,7 @@ class AddDependencyMojoTest {
8482

8583
@DisplayName("should return error when")
8684
@ParameterizedTest(name = "groupId={0}, artifactId={1}")
87-
@MethodSource("invalidParameters")
85+
@ArgumentsSource(InvalidGroupIdArtifactIdArgs.class)
8886
void shouldReturnErrorsForInvalidRequiredParameters(final String groupId,
8987
final String artifactId) {
9088
Assertions.assertThrows(MojoExecutionException.class, () -> {
@@ -99,36 +97,6 @@ void shouldReturnErrorsForInvalidRequiredParameters(final String groupId,
9997
verify(rollbackFunction, never()).accept(any());
10098
}
10199

102-
static Stream<Arguments> invalidParameters() {
103-
return Stream.of(
104-
arguments(
105-
null, // groupId,
106-
null // artifactId,
107-
),
108-
arguments(
109-
null, // groupId,
110-
"artifactId" // artifactId,
111-
),
112-
arguments(
113-
"groupId", // groupId,
114-
null // artifactId,
115-
),
116-
arguments(
117-
"", // groupId,
118-
"" // artifactId,
119-
),
120-
arguments(
121-
"", // groupId,
122-
"artifactId" // artifactId,
123-
),
124-
arguments(
125-
"groupId", // groupId,
126-
"" // artifactId,
127-
)
128-
);
129-
}
130-
131-
132100
@Test
133101
void shouldAddDependencyProperly() throws MojoExecutionException, MojoFailureException {
134102

0 commit comments

Comments
 (0)