Use Appender in more cases

Author: mathiascode

src/pwhash.d

@@ -6,6 +6,7 @@ module soulfind.pwhash;
 @safe:
 
 import std.algorithm.iteration : splitter;
+import std.array : Appender;
 import std.bitmanip : nativeToBigEndian;
 import std.conv : ConvException, text, to;
 import std.digest : LetterCase, secureEqual, toHexString;
@@ -128,8 +129,8 @@ void verify_password_async(string hash, string password,
 
 void process_password_tasks()
 {
-    HashCallback[]    hash_password_tasks_to_remove;
-    VerifyCallback[]  verify_password_tasks_to_remove;
+    Appender!(HashCallback[])    hash_password_tasks_to_remove;
+    Appender!(VerifyCallback[])  verify_password_tasks_to_remove;
 
     foreach (ref callback, ref task ; hash_password_tasks) {
         if (!task.done)

src/server/cmdhandler.d

@@ -346,7 +346,7 @@ final class CommandHandler
                     break;
                 }
             }
-            User[] users_to_kick;
+            Appender!(User[]) users_to_kick;
             foreach (ref user ; server.connected_users)
                 if (user.username != admin_username)
                     users_to_kick ~= user;

src/server/conns.d

@@ -14,6 +14,7 @@ import soulfind.server.msghandler : MessageHandler;
 import soulfind.server.select : DefaultSelector, SelectEvent, Selector;
 import soulfind.server.server : Server;
 import soulfind.server.user : User;
+import std.array : Appender;
 import std.bitmanip : Endian, nativeToLittleEndian, peek, read;
 import std.datetime : MonoTime, msecs;
 import std.socket : InternetAddress, parseAddress, Socket, socket_t,
@@ -89,7 +90,7 @@ final class UserConnections
 
             // Check expired login attempts and unsearchable users
             if ((current_time - last_user_check) >= user_check_interval) {
-                User[] expired_users;
+                Appender!(User[]) expired_users;
                 foreach (ref user ; sock_users)
                     if (user.login_timed_out(current_time))
                         expired_users ~= user;

src/server/select.d

@@ -5,6 +5,7 @@
 module soulfind.server.select;
 @safe:
 
+import std.array : Appender;
 import std.datetime : Duration;
 import std.socket : socket_t;
 
@@ -288,7 +289,7 @@ final class PollSelector : Selector
         import core.sys.posix.poll;
     }
 
-    private pollfd[]               pollfds;
+    private Appender!(pollfd[]) pollfds;
 
     this(Duration timeout)
     {
@@ -304,7 +305,7 @@ final class PollSelector : Selector
         const pfd = create_pollfd(fd, events);
 
         if (is_registered)
-            pollfds[find_fd_idx(fd)] = pfd;
+            pollfds[][find_fd_idx(fd)] = pfd;
         else
             pollfds ~= pfd;
 
@@ -322,11 +323,11 @@ final class PollSelector : Selector
 
         if (remaining_events == 0) {
             fd_events.remove(fd);
-            pollfds[idx] = pollfds[$ - 1];
-            pollfds.length--;
+            pollfds[][idx] = pollfds[][$ - 1];
+            pollfds[].length--;
             return;
         }
-        pollfds[idx] = create_pollfd(fd, remaining_events);
+        pollfds[][idx] = create_pollfd(fd, remaining_events);
     }
 
     override ReadyFD[] select()
@@ -379,7 +380,7 @@ final class PollSelector : Selector
     private int wait()
     {
         return poll(
-            pollfds.ptr, cast(uint) pollfds.length,
+            pollfds[].ptr, cast(uint) pollfds.length,
             cast(int) timeout.total!"msecs"
         );
     }

src/server/server.d

@@ -248,7 +248,7 @@ final class Server
 
     void del_user_pms(string username, bool include_received = false)
     {
-        PM[] pms_to_remove;
+        Appender!(PM[]) pms_to_remove;
         foreach (ref pm ; pms) {
             if (pm.from_username == username
                     || (include_received && pm.to_username == username))
@@ -387,20 +387,19 @@ final class Server
     private Recommendation[] filter_recommendations(
         int[string] recommendations, size_t max_length, bool ascending = false)
     {
-        Recommendation[] filtered_recommendations;
+        Appender!(Recommendation[]) filtered_recommendations;
         foreach (ref item, ref rating ; recommendations)
             if (rating != 0)
                 filtered_recommendations ~= Recommendation(item, rating);
 
-        filtered_recommendations.sort!(
+        filtered_recommendations[].sort!(
             (ref a, ref b)
             => ascending ? a.rating < b.rating : a.rating > b.rating
         );
-
         if (filtered_recommendations.length > max_length)
-            filtered_recommendations.length = max_length;
+            return filtered_recommendations[][0 .. max_length];
 
-        return filtered_recommendations;
+        return filtered_recommendations[];
     }