db.d: remove get_ticker() method

We can add/remove tickers without using it.

Author: mathiascode

src/db.d

@@ -977,31 +977,41 @@ final class Database
         return members[];
     }
 
-    void add_ticker(string room_name, string username, string content)
+    bool add_ticker(string room_name, string username, string content)
     {
-        enum sql = text(
-            "INSERT INTO ", tickers_table,
+        enum check_sql = text(
+            "SELECT 1 FROM ", tickers_table,
+            " WHERE room = ? AND username = ? AND content = ?;"
+        );
+        enum add_sql = text(
+            "REPLACE INTO ", tickers_table,
             "(room, username, content) VALUES(?, ?, ?);"
         );
-        query(sql, [room_name, username, content]);
+        const res = query(check_sql, [room_name, username, content]);
+
+        if (res.length > 0)
+            return false;
+
+        query(add_sql, [room_name, username, content]);
+        return true;
     }
 
-    string get_ticker(string room_name, string username)
+    bool del_ticker(string room_name, string username)
     {
-        enum sql = text(
-            "SELECT content FROM ", tickers_table,
+        enum check_sql = text(
+            "SELECT 1 FROM ", tickers_table,
             " WHERE room = ? AND username = ?;"
         );
-        const res = query(sql, [room_name, username]);
-        return res.length > 0 ? res[0][0] : null;
-    }
-
-    void del_ticker(string room_name, string username)
-    {
-        enum sql = text(
+        enum del_sql = text(
             "DELETE FROM ", tickers_table, " WHERE room = ? AND username = ?;"
         );
-        query(sql, [room_name, username]);
+        const res = query(check_sql, [room_name, username]);
+
+        if (res.length == 0)
+            return false;
+
+        query(del_sql, [room_name, username]);
+        return true;
     }
 
     string del_oldest_ticker(string room_name)

src/server/room.d

@@ -137,17 +137,16 @@ final class Room
         if (content.length > max_room_ticker_length)
             return;
 
-        const old_content = get_ticker(username);
-        if (content == old_content)
-            return;
-
-        if (old_content !is null)
+        if (content.length == 0) {
             del_ticker(username);
+            return;
+        }
 
-        if (content.length == 0)
+        if (!db.add_ticker(name, username, content))
             return;
 
-        db.add_ticker(name, username, content);
+        enum permanent = false;
+        del_ticker(username, permanent);
 
         if (num_tickers >= max_room_tickers)
             del_oldest_ticker ();
@@ -156,9 +155,10 @@ final class Room
         send_to_all(msg);
     }
 
-    void del_ticker(string username)
+    void del_ticker(string username, bool permanent = true)
     {
-        db.del_ticker(name, username);
+        if (permanent && !db.del_ticker(name, username))
+            return;
 
         scope msg = new SRoomTickerRemove(name, username);
         send_to_all(msg);
@@ -179,11 +179,6 @@ final class Room
         send_to_all(msg);
     }
 
-    private string get_ticker(string username)
-    {
-        return db.get_ticker(name, username);
-    }
-
     private RoomTicker[] tickers()
     {
         return db.room_tickers(name);