Bump version to 0.5.0, update dependencies, and pin Rust 1.91 in CI (#12)

* Bump version to 0.5.0, update dependencies, and pin Rust 1.91 in CI

- Update all crate dependencies to latest compatible versions (46 packages)
- Sync package version to 0.5.0 across Cargo.toml, VERSION, and Helm charts
- Pin CI workflow to Rust 1.91 for consistent builds

* Improve CI workflow with separate lint/test/build jobs

- Split monolithic build job into lint, test, and build stages
- Add pull_request trigger for PR validation
- Docker push only on main branch (DO_PUSH condition)
- Use GitHub Actions cache (type=gha) for non-main builds
- Add explicit permissions (contents: read)
- Improve clippy check with --all-targets flag
- Include Rust version in cache key for consistency

* Sync lint commands and fix clippy warnings

- Split Makefile lint into lint (check) and lint_fix (auto-fix)
- Update dev_check to use lint_fix for convenience
- CI workflow now uses make lint for consistency
- Fix collapsible_if warnings using let chains (Rust 2024)
- Fix bool_assert_comparison: use assert!(!expr) instead of assert_eq!(expr, false)
- Fix assertions_on_constants: remove useless assert!(true)
- Fix len_zero: use !is_empty() instead of len() >= 1

Author: soulgarden

.github/workflows/main.yml

@@ -1,36 +1,64 @@
 name: Lint & test & build
 
-on: push
+on:
+  push:
+  pull_request:
+
+permissions:
+  contents: read
+
+env:
+  DO_PUSH: ${{ github.ref == 'refs/heads/main' && github.event_name == 'push' }}
 
 jobs:
-  build:
+  lint:
     runs-on: ubuntu-latest
-
     steps:
       - uses: actions/checkout@v4
 
       - name: Set up Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@1.91
         with:
           components: rustfmt, clippy
 
+      - name: Check formatting
+        run: cargo fmt --all -- --check
+
+      - name: Run Clippy
+        run: make lint
+
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Rust
+        uses: dtolnay/rust-toolchain@1.91
+
       - name: Cache cargo dependencies
         uses: actions/cache@v4
         with:
           path: |
             ~/.cargo/registry
             ~/.cargo/git
             target
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+          key: ${{ runner.os }}-rust-1.91-${{ hashFiles('**/Cargo.lock') }}
 
-      - name: Run CI pipeline
-        run: make ci
+      - name: Run tests
+        run: cargo test -- --test-threads=1
+
+  build:
+    needs: [lint, test]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
 
       - name: Get version
         id: version
         run: echo "VERSION=$(cat VERSION)" >> $GITHUB_OUTPUT
 
       - name: Login to Docker Hub
+        if: ${{ env.DO_PUSH == 'true' }}
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKER_HUB_USERNAME }}
@@ -39,8 +67,19 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Build and push Docker image
-        id: docker_build
+      - name: Build Docker image (PR/branch)
+        if: ${{ env.DO_PUSH == 'false' }}
+        uses: docker/build-push-action@v6
+        with:
+          context: .
+          file: Dockerfile
+          push: false
+          tags: logfowd2:${{ steps.version.outputs.VERSION }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+
+      - name: Build and push Docker image (main)
+        if: ${{ env.DO_PUSH == 'true' }}
         uses: docker/build-push-action@v6
         with:
           context: .
@@ -51,6 +90,3 @@ jobs:
             ${{ secrets.DOCKER_HUB_USERNAME }}/logfowd2:latest
           cache-from: type=registry,ref=${{ secrets.DOCKER_HUB_USERNAME }}/logfowd2:latest
           cache-to: type=registry,ref=${{ secrets.DOCKER_HUB_USERNAME }}/logfowd2:latest,mode=max
-
-      - name: Image digest
-        run: echo ${{ steps.docker_build.outputs.digest }}