added custom error page with test cases

theparadoxer02 · nishutosh · commit 4c88fb3ce178 · 2017-08-27T10:18:21.000+05:30
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -10,7 +10,6 @@ Contribution are welcome as always. Checkout the existing issues or create issue
 
 - Always branch from updated `development` branch locally.
 
-
 	- If resolving an issue then create a branch with name like `bugfix-#<issue_number>` or `enhancement-#<issue_number>`.
 
 - Write a commit messages describing the changes you made
diff --git a/code_share/app_code_share/templates/error/HTTP400.html b/code_share/app_code_share/templates/error/HTTP400.html
@@ -0,0 +1,24 @@
+{% load staticfiles %}
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <!-- Simple HttpErrorPages | MIT X11 License | https://github.com/AndiDittrich/HttpErrorPages -->
+
+    <meta charset="utf-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+
+    <link rel="stylesheet" href="{% static 'css/error.css' %}">
+    
+    <title>We've got some trouble | 400 - Bad Request</title>
+
+</head>
+
+<body>
+    <div class="cover">
+        <h1>Bad Request <small>Error 400</small></h1>
+        <p class="lead">The server cannot process the request due to something that is perceived to be a client error.</p>
+    </div>
+    
+    </body>
+</html>
diff --git a/code_share/app_code_share/templates/error/HTTP403.html b/code_share/app_code_share/templates/error/HTTP403.html
@@ -0,0 +1,23 @@
+{% load staticfiles %}
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <!-- Simple HttpErrorPages | MIT X11 License | https://github.com/AndiDittrich/HttpErrorPages -->
+
+    <meta charset="utf-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <link rel="stylesheet" href="{% static 'css/error.css' %}">
+    
+    <title>We've got some trouble | 403 - Access Denied</title>
+
+</head>
+
+<body>
+    <div class="cover">
+        <h1>Access Denied <small>Error 403</small></h1>
+        <p class="lead">The requested resource requires an authentication.</p>
+    </div>
+    
+    </body>
+</html>
diff --git a/code_share/app_code_share/templates/error/HTTP404.html b/code_share/app_code_share/templates/error/HTTP404.html
@@ -0,0 +1,24 @@
+{% load staticfiles %}
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <!-- Simple HttpErrorPages | MIT X11 License | https://github.com/AndiDittrich/HttpErrorPages -->
+
+    <meta charset="utf-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    
+    <title>We've got some trouble | 404 - Resource not found</title>
+
+    <link rel="stylesheet" href="{% static 'css/error.css' %}">
+
+</head>
+
+<body>
+    <div class="cover">
+        <h1>Resource not found <small>Error 404</small></h1>
+        <p class="lead">The requested resource could not be found but may be available again in the future.</p>
+    </div>
+    
+    </body>
+</html>
diff --git a/code_share/app_code_share/templates/error/HTTP500.html b/code_share/app_code_share/templates/error/HTTP500.html
@@ -0,0 +1,24 @@
+{% load staticfiles %}
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <!-- Simple HttpErrorPages | MIT X11 License | https://github.com/AndiDittrich/HttpErrorPages -->
+
+    <meta charset="utf-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    
+    <title>We've got some trouble | 500 - Webservice currently unavailable</title>
+    <link rel="stylesheet" href="{% static 'css/error.css' %}">
+
+</head>
+
+<body>
+    <div class="cover">
+        <h1>Webservice currently unavailable <small>Error 500</small></h1>
+        <p class="lead">An unexpected condition was encountered.<br />
+Our service team has been dispatched to bring it back online.</p>
+    </div>
+    
+    </body>
+</html>
diff --git a/code_share/app_code_share/tests/test_urls.py b/code_share/app_code_share/tests/test_urls.py
@@ -2,6 +2,14 @@
 from test_plus.test import TestCase
 from app_code_share.models import CodeShare
 from django.utils.crypto import get_random_string
+from django.test.client import RequestFactory
+
+from code_share.views import (
+    page_not_found_view,
+    my_custom_error_view,
+    permission_denied_view,
+    bad_request_view,
+)
 
 
 
@@ -35,3 +43,31 @@ def test_detail_resolve(self):
             resolve('/app/' + self.hash_value + '/').view_name,
             'code_share:view_by_hash'
         )
+
+
+class TestMyErrorPages(TestCase):
+
+    def test_400_error(self):
+        factory = RequestFactory()
+        request = factory.get('/400')
+        response = bad_request_view(request)
+        self.assertEqual(response.status_code, 400)
+
+    def test_403_error(self):
+        factory = RequestFactory()
+        request = factory.get('/403')
+        response = permission_denied_view(request)
+        self.assertEqual(response.status_code, 403)
+
+    def test_404_error(self):
+        factory = RequestFactory()
+        request = factory.get('/404')
+        response = page_not_found_view(request)
+        self.assertEqual(response.status_code, 404)
+
+    def test_500_error(self):
+        factory = RequestFactory()
+        request = factory.get('/500')
+        response = my_custom_error_view(request)
+        self.assertEqual(response.status_code, 500)
+
diff --git a/code_share/app_code_share/views.py b/code_share/app_code_share/views.py
@@ -1,7 +1,8 @@
 from django.shortcuts import render, redirect, get_object_or_404 as goo404
 from .models import CodeShare
-import random
 from django.utils.crypto import get_random_string
+from django.http import Http404
+
 
 
 def home(request):
@@ -31,10 +32,8 @@ def home(request):
         code_share = request.POST.get('code_snippet')
         file_name = request.POST.get('file_name')
         language = request.POST.get('language')
-
         chars = 'abcdefghijklmnopqrstuvwxyz0123456789'
-        hash_value= get_random_string(8, chars) 
-
+        hash_value = get_random_string(8, chars)
         CodeShare.objects.create(code=code_share,
                                  hash_value=hash_value,
                                  file_name=file_name,
@@ -64,12 +63,16 @@ def view_by_hash(request, hash_id):
     """
 
     if request.method == 'GET':
-        code_share = CodeShare.objects.get(hash_value=hash_id)
-        return render(request, 'app_code_share/code_view.html', {'code_share': code_share})
+        try:
+            code_share = CodeShare.objects.get(hash_value=hash_id)
+        except CodeShare.DoesNotExist:
+            raise Http404("Codeshare does not exist")
+        context = {'code_share': code_share, "filename": "yes"}
+        return render(request, 'app_code_share/homepage.html', context)
 
     if request.method == 'POST':
         code_share = request.POST.get('code_snippet')
-        language =request.POST.get('language')
+        language = request.POST.get('language')
         code_obj = goo404(CodeShare, hash_value=hash_id)
         code_obj.code = code_share
         code_obj.language = language
diff --git a/code_share/code_share/urls.py b/code_share/code_share/urls.py
@@ -2,9 +2,29 @@
 from django.contrib import admin
 from django.conf import settings
 from django.conf.urls.static import static
+from .views import (
+    page_not_found_view,
+    my_custom_error_view,
+    permission_denied_view,
+    bad_request_view,
+)
+
 
 urlpatterns = [
     url(r'^admin', admin.site.urls),
     url(r'^', include('app_code_share.urls', namespace='code_share')),
     url(r'^api/', include('api_app.urls')),
 ] + static(settings.STATIC_URL, document_root=settings.STATIC_ROOT)
+
+if settings.DEBUG:
+    urlpatterns += [
+        url(r'^404/$', page_not_found_view),
+        url(r'^500/$', my_custom_error_view),
+        url(r'^400/$', bad_request_view),
+        url(r'^403/$', permission_denied_view),
+    ]
+
+handler404 = page_not_found_view
+handler500 = my_custom_error_view
+handler403 = permission_denied_view
+handler400 = bad_request_view
diff --git a/code_share/code_share/views.py b/code_share/code_share/views.py
@@ -0,0 +1,31 @@
+from django.template import loader
+from django.http import (
+    HttpResponseNotFound,
+    HttpResponseServerError,
+    HttpResponseForbidden,
+    HttpResponseBadRequest,
+)
+
+
+def page_not_found_view(request):
+    t = loader.get_template('error/HTTP404.html')
+    html = html = t.render({})
+    return HttpResponseNotFound(html)
+
+
+def my_custom_error_view(request):
+    t = loader.get_template('error/HTTP500.html')
+    html = html = t.render({})
+    return HttpResponseServerError(html)
+
+
+def permission_denied_view(request):
+    t = loader.get_template('error/HTTP403.html')
+    html = html = t.render({})
+    return HttpResponseForbidden(html)
+
+
+def bad_request_view(request):
+    t = loader.get_template('error/HTTP400.html')
+    html = html = t.render({})
+    return HttpResponseBadRequest(html)
diff --git a/code_share/static/css/error.css b/code_share/static/css/error.css
@@ -0,0 +1,101 @@
+
+html { font-family:sans-serif;line-height:1.15;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100% }
+
+body { margin:0 }
+
+article,aside,footer,header,nav,section{ display:block }
+
+h1 { font-size:2em;margin:.67em0 }
+
+figcaption,figure,main{ display:block }
+
+figure{ margin:1em 40px }
+
+hr { box-sizing:content-box;height:0;overflow:visible }
+
+pre { font-family:monospace,monospace;font-size:1em } 
+
+a{ background-color:transparent;-webkit-text-decoration-skip:objects }
+
+a:active,a:hover{ outline-width:0 }
+
+abbr[title]{ border-bottom:none;text-decoration:underline;text-decoration:underline dotted }
+
+b,strong{ font-weight:inherit }
+
+b,strong{ font-weight:bolder }
+
+code,kbd,samp{ font-family:monospace,monospace;font-size:1em }
+
+dfn{ font-style:italic }
+
+mark{ background-color:#ff0;color:#000 }
+
+small{ font-size:80% }
+
+sub,sup{ font-size:75%;line-height:0;position:relative;vertical-align:baseline }
+
+sub{ bottom:-.25em }
+
+sup{ top:-.5em }
+
+audio,video{ display:inline-block }
+
+audio:not([controls]){ display:none;height:0 }
+
+img{border-style:none}svg:not(:root){ overflow:hidden }
+
+button,input,optgroup,select,textarea{ font-family:sans-serif;font-size:100%;line-height:1.15;margin:0 }
+
+button,input{ overflow:visible }
+
+button,select{ text-transform:none }
+
+[type=reset],[type=submit],button,html
+
+[type=button]{-webkit-appearance:button}[type=button]::-moz-focus-inner,[type=reset]::-moz-focus-inner,[type=submit]::-moz-focus-inner,button::-moz-focus-inner{ border-style:none;padding:0 }
+
+[type=button]:-moz-focusring,[type=reset]:-moz-focusring,[type=submit]:-moz-focusring,button:-moz-focusring{ outline:1pxdottedButtonText }
+
+fieldset{ border:1px solid silver;margin:0 2px;padding:.35em .625em .75em }
+
+legend{ box-sizing:border-box;color:inherit;display:table;max-width:100%;padding:0;white-space:normal }
+
+progress{ display:inline-block;vertical-align:baseline }
+
+textarea{ overflow:auto}[type=checkbox],[type=radio]{ box-sizing:border-box;padding:0 }
+
+[type=number]::-webkit-inner-spin-button,[type=number]::-webkit-outer-spin-button{ height:auto }
+
+[type=search]{ -webkit-appearance:textfield;outline-offset:-2px }
+
+[type=search]::-webkit-search-cancel-button,[type=search]::-webkit-search-decoration{-webkit-appearance:none}::-webkit-file-upload-button{-webkit-appearance:button;font:inherit}
+
+details,menu{display:block}summary{display:list-item}
+
+canvas{display:inline-block}template{display:none}[hidden]{display:none}/*!
+
+*/
+body,html { width:100%;height:100%;background-color:#21232a }
+
+body {
+    color:#fff;text-align:center;text-shadow:0 2px 4px
+    rgba(0,0,0,.5);padding:0;min-height:100%;-webkit-box-shadow:inset 0 0 75pt
+    rgba(0,0,0,.8);box-shadow:inset 0 0 75pt
+    rgba(0,0,0,.8);display:table;font-family:"Open Sans",Arial,sans-serif 
+}
+
+h1{font-family:inherit;font-weight:500;line-height:1.1;color:inherit;font-size:36px}h1
+
+small{font-size:68%;font-weight:400;line-height:1;color:#777}
+
+a{text-decoration:none;color:#fff;font-size:inherit;border-bottom:dotted 1px #707070}
+
+.lead{color:silver;font-size:21px;line-height:1.4}
+
+.cover{display:table-cell;vertical-align:middle;padding:0 20px}
+
+footer{position:fixed;width:100%;height:40px;left:0;bottom:0;color:#a0a0a0;font-size:14px}</style>
+
+
+
