fix: reduce warnings when running tests (#1270)

* replace warn with warning

"warning: the log level :warn is deprecated, use :warning instead"

* empty doc

"warning: module attribute @doc was set but no definition follows it"

* replace '' with ""

"warning: using single-quoted strings to represent charlists is deprecated."

* move function

"clauses with the same name and arity (number of arguments) should be grouped together"

* make range explicit

"10..0 has a default step of -1, please write 10..0//-1 instead"

* remove alias

"unused alias"

* rename unused variables

"warning: variable "XXX" is unused"

* remove choices from validate_required

"""
warning: attempting to determine the presence of embed_many field :choices with validate_required/3 ... which has no effect.
You can pass the :required option to Ecto.Changeset.cast_embed/3 to achieve this.
"""

* delete unused variables instead

* Revert "remove choices from validate_required"

This reverts commit 088fa96.

Author: heyzec

config/test.exs

@@ -9,7 +9,7 @@ config :cadet, CadetWeb.Endpoint,
 config :cadet, environment: :test
 
 # Print only warnings and errors during test
-config :logger, level: :warn, compile_time_purge_matching: [[level_lower_than: :warn]]
+config :logger, level: :warning, compile_time_purge_matching: [[level_lower_than: :warning]]
 
 config :ex_aws,
   access_key_id: "hello",

lib/cadet/accounts/teams.ex

@@ -64,8 +64,6 @@ defmodule Cadet.Accounts.Teams do
 
       true ->
         Enum.reduce_while(attrs["student_ids"], {:ok, nil}, fn team_attrs, {:ok, _} ->
-          student_ids = Enum.map(team_attrs, &Map.get(&1, "userId"))
-
           {:ok, team} =
             %Team{}
             |> Team.changeset(attrs)
@@ -105,7 +103,6 @@ defmodule Cadet.Accounts.Teams do
       ids = Enum.map(team, &Map.get(&1, "userId"))
 
       unique_ids_count = ids |> Enum.uniq() |> Enum.count()
-      all_ids_distinct = unique_ids_count == Enum.count(ids)
 
       student_already_in_team?(-1, ids, assessment_id)
     end)
@@ -229,7 +226,6 @@ defmodule Cadet.Accounts.Teams do
 
   """
   def update_team(team = %Team{}, new_assessment_id, student_ids) do
-    old_assessment_id = team.assessment_id
     team_id = team.id
     new_student_ids = Enum.map(hd(student_ids), fn student -> Map.get(student, "userId") end)
 

lib/cadet/devices/devices.ex

@@ -212,7 +212,7 @@ defmodule Cadet.Devices do
               },
               300,
               [],
-              ''
+              ""
             )
 
           # ExAws includes the session token in the signed payload and doesn't allow

lib/cadet/jobs/autograder/lambda_worker.ex

@@ -21,7 +21,7 @@ defmodule Cadet.Autograder.LambdaWorker do
     lambda_params = build_request_params(params)
 
     if Enum.empty?(lambda_params.testcases) do
-      Logger.warn("No testcases found. Skipping autograding for answer_id: #{answer.id}")
+      Logger.warning("No testcases found. Skipping autograding for answer_id: #{answer.id}")
       # Fix for https://github.com/source-academy/backend/issues/472
       Process.sleep(1000)
     else

lib/cadet/jobs/xml_parser.ex

@@ -34,7 +34,7 @@ defmodule Cadet.Updater.XMLParser do
       :ok
     else
       {:error, stage, %{errors: [assessment: {"has submissions", []}]}, _} when is_atom(stage) ->
-        Logger.warn("Assessment has submissions, ignoring...")
+        Logger.warning("Assessment has submissions, ignoring...")
         {:ok, "Assessment has submissions, ignoring..."}
 
       {:error, error_message} ->

lib/cadet/notifications.ex

@@ -276,15 +276,15 @@ defmodule Cadet.Notifications do
     |> Repo.insert()
   end
 
-  @doc """
-  Returns the list of sent_notifications.
+  # @doc """
+  # Returns the list of sent_notifications.
 
-  ## Examples
+  # ## Examples
 
-      iex> list_sent_notifications()
-      [%SentNotification{}, ...]
+  #    iex> list_sent_notifications()
+  #    [%SentNotification{}, ...]
 
-  """
+  # """
 
   # def list_sent_notifications do
   #   Repo.all(SentNotification)

lib/cadet_web/admin_controllers/admin_stories_controller.ex

@@ -12,7 +12,7 @@ defmodule CadetWeb.AdminStoriesController do
 
     case result do
       {:ok, _story} ->
-        conn |> put_status(200) |> text('')
+        conn |> put_status(200) |> text("")
 
       {:error, {status, message}} ->
         conn
@@ -29,7 +29,7 @@ defmodule CadetWeb.AdminStoriesController do
 
     case result do
       {:ok, _story} ->
-        conn |> put_status(200) |> text('')
+        conn |> put_status(200) |> text("")
 
       {:error, {status, message}} ->
         conn
@@ -43,7 +43,7 @@ defmodule CadetWeb.AdminStoriesController do
 
     case result do
       {:ok, _nil} ->
-        conn |> put_status(204) |> text('')
+        conn |> put_status(204) |> text("")
 
       {:error, {status, message}} ->
         conn

lib/cadet_web/controllers/answer_controller.ex

@@ -38,6 +38,10 @@ defmodule CadetWeb.AnswerController do
     end
   end
 
+  def submit(conn, _params) do
+    send_resp(conn, :bad_request, "Missing or invalid parameter(s)")
+  end
+
   def check_last_modified(conn, %{
         "questionid" => question_id,
         "lastModifiedAt" => last_modified_at
@@ -79,10 +83,6 @@ defmodule CadetWeb.AnswerController do
     end
   end
 
-  def submit(conn, _params) do
-    send_resp(conn, :bad_request, "Missing or invalid parameter(s)")
-  end
-
   swagger_path :submit do
     post("/assessments/question/{questionId}/answer")
 

test/cadet/assessments/assessments_test.exs

@@ -2223,7 +2223,7 @@ defmodule Cadet.AssessmentsTest do
 
     test "limit submisssions 2", %{
       course_regs: %{avenger1_cr: avenger},
-      assessments: assessments
+      assessments: _assessments
     } do
       {_, res} =
         Assessments.submissions_by_grader_for_index(avenger, %{
@@ -3142,7 +3142,7 @@ defmodule Cadet.AssessmentsTest do
 
   defp expected_top_relative_scores(top_x, token_divider) do
     # "return 0;" in the factory has 3 token
-    10..0
+    10..0//-1
     |> Enum.to_list()
     |> Enum.map(fn score -> 10 * score - :math.pow(2, 3 / token_divider) end)
     |> Enum.take(top_x)

test/cadet_web/admin_controllers/admin_assessments_controller_test.exs

@@ -5,7 +5,7 @@ defmodule CadetWeb.AdminAssessmentsControllerTest do
   import Ecto.Query
   import ExUnit.CaptureLog
 
-  alias Cadet.{Assessments, Repo}
+  alias Cadet.Repo
   alias Cadet.Accounts.CourseRegistration
   alias Cadet.Assessments.{Assessment, Submission}
   alias Cadet.Test.XMLGenerator