bug fix + credo fixes

Author: Tkaixiang

lib/cadet_web/admin_controllers/admin_grading_controller.ex

@@ -2,8 +2,7 @@ defmodule CadetWeb.AdminGradingController do
   use CadetWeb, :controller
   use PhoenixSwagger
 
-  alias Cadet.Assessments
-  alias Cadet.Courses
+  alias Cadet.{Assessments, Courses}
 
   @doc """
   # Query Parameters

lib/cadet_web/controllers/generate_ai_comments.ex

@@ -65,7 +65,7 @@ defmodule CadetWeb.AICodeAnalysisController do
         {:error, "LLM course-level prompt is not configured for this course"}
 
       true ->
-        :ok
+        {:ok}
     end
   end
 
@@ -99,7 +99,7 @@ defmodule CadetWeb.AICodeAnalysisController do
               |> put_status(:bad_request)
               |> text(error_msg)
 
-            true ->
+            {:ok} ->
               case Assessments.get_answers_in_submission(submission_id, question_id) do
                 {:ok, {answers, _assessment}} ->
                   case answers do
@@ -114,13 +114,13 @@ defmodule CadetWeb.AICodeAnalysisController do
                       analyze_code(
                         conn,
                         %{
-                          answers: hd(answers),
+                          answer: hd(answers),
                           submission_id: submission_id,
                           question_id: question_id,
                           api_key: api_key,
                           llm_model: course.llm_model,
                           llm_api_url: course.llm_api_url,
-                          llm_course_level_prompt: course.llm_course_level_prompt,
+                          course_prompt: course.llm_course_level_prompt,
                           assessment_prompt: Assessments.get_llm_assessment_prompt(question_id)
                         }
                       )

test/cadet_web/controllers/ai_code_analysis_controller_test.exs

@@ -2,10 +2,8 @@ import Mock
 
 defmodule CadetWeb.AICodeAnalysisControllerTest do
   use CadetWeb.ConnCase
-  alias Cadet.AIComments
-  alias Cadet.AIComments.AIComment
-  alias Cadet.Courses.Course
-  alias Cadet.Repo
+  alias Cadet.{Repo, AIComments}
+  alias Cadet.{AIComments.AIComment, Courses.Course}
 
   setup do
     course_with_llm =