Skip to content

Commit 8796fb7

Browse files
committed
fix: Fix creation of empty submission for teams
1 parent de0f910 commit 8796fb7

File tree

1 file changed

+19
-14
lines changed

1 file changed

+19
-14
lines changed

lib/cadet/jobs/autograder/grading_job.ex

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -112,23 +112,28 @@ defmodule Cadet.Autograder.GradingJob do
112112
|> where([_, tm], tm.student_id == ^student_id)
113113
|> Repo.one()
114114

115-
if !team do
116-
# Student is not in any team
117-
# Create new team just for the student
118-
team =
119-
%Team{}
120-
|> Team.changeset(%{
121-
assessment_id: assessment.id
115+
team =
116+
if !team do
117+
# Student is not in any team
118+
# Create new team just for the student
119+
team =
120+
%Team{}
121+
|> Team.changeset(%{
122+
assessment_id: assessment.id
123+
})
124+
|> Repo.insert!()
125+
126+
%TeamMember{}
127+
|> TeamMember.changeset(%{
128+
team_id: team.id,
129+
student_id: student_id
122130
})
123131
|> Repo.insert!()
124132

125-
%TeamMember{}
126-
|> TeamMember.changeset(%{
127-
team_id: team.id,
128-
student_id: student_id
129-
})
130-
|> Repo.insert!()
131-
end
133+
team
134+
else
135+
team
136+
end
132137

133138
%Submission{}
134139
|> Submission.changeset(%{

0 commit comments

Comments
 (0)