Skip to content

Commit 9686184

Browse files
committed
Transfer asset routes to admin
1 parent 79c5a5d commit 9686184

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/cadet_web/router.ex

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ defmodule CadetWeb.Router do
136136
scope "/v2/courses/:course_id/admin", CadetWeb do
137137
pipe_through([:api, :auth, :ensure_auth, :course, :ensure_admin])
138138

139+
get("/assets/:foldername", AdminAssetsController, :index)
139140
post("/assets/:foldername/*filename", AdminAssetsController, :upload)
140141
delete("/assets/:foldername/*filename", AdminAssetsController, :delete)
141142

@@ -188,8 +189,6 @@ defmodule CadetWeb.Router do
188189
:get_score_leaderboard
189190
)
190191

191-
get("/assets/:foldername", AdminAssetsController, :index)
192-
193192
get("/grading", AdminGradingController, :index)
194193
get("/grading/summary", AdminGradingController, :grading_summary)
195194

test/cadet_web/admin_controllers/admin_assets_controller_test.exs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,13 @@ defmodule CadetWeb.AdminAssetsControllerTest do
6868
end
6969
end
7070

71-
describe "read-only permission for non-admin staff" do
71+
describe "non-admin staff permission, forbidden" do
7272
@tag authenticate: :staff
7373
test "GET /assets/:foldername", %{conn: conn} do
7474
course_id = conn.assigns.course_id
7575
conn = get(conn, build_url(course_id, "testFolder"), %{})
76-
assert response(conn, 200) =~ "OK"
76+
77+
assert response(conn, 403) =~ "Forbidden"
7778
end
7879

7980
@tag authenticate: :staff

0 commit comments

Comments
 (0)