some mix credo suggestions

Author: Tkaixiang

lib/cadet/assessments/assessments.ex

@@ -3050,7 +3050,8 @@ defmodule Cadet.Assessments do
     base_query =
       Answer
       |> where(submission_id: ^id)
-      # [a] are bindings (in SQL it is similar to FROM answers "AS a"), this line's alias is INNER JOIN ... "AS q"
+      # [a] are bindings (in SQL it is similar to FROM answers "AS a"),
+      # this line's alias is INNER JOIN ... "AS q"
       |> join(:inner, [a], q in assoc(a, :question))
       |> join(:inner, [_, q], ast in assoc(q, :assessment))
       |> join(:inner, [..., ast], ac in assoc(ast, :config))
@@ -3555,11 +3556,12 @@ defmodule Cadet.Assessments do
   end
 
   def get_llm_assessment_prompt(question_id) do
-    from(q in Question,
+    query = from(q in Question,
       where: q.id == ^question_id,
       join: a in assoc(q, :assessment),
       select: a.llm_assessment_prompt
     )
-    |> Repo.one()
+
+    Repo.one(query)
   end
 end

lib/cadet_web/controllers/generate_ai_comments.ex

@@ -100,7 +100,8 @@ defmodule CadetWeb.AICodeAnalysisController do
                       |> text("No answer found for the given submission and question_id")
 
                     _ ->
-                      # Get head of answers (should only be one answer for given submission and question since we filter to only 1 question)
+                      # Get head of answers (should only be one answer for given submission
+                      # and question since we filter to only 1 question)
                       analyze_code(
                         conn,
                         hd(answers),
@@ -210,7 +211,8 @@ defmodule CadetWeb.AICodeAnalysisController do
          assessment_prompt
        ) do
     formatted_answer =
-      format_student_answer(answer)
+      answer
+      |> format_student_answer()
       |> Jason.encode!()
 
     system_prompt = format_system_prompt(course_prompt, assessment_prompt, answer)

test/cadet_web/controllers/ai_code_analysis_controller_test.exs

@@ -5,7 +5,7 @@ defmodule CadetWeb.AICodeAnalysisControllerTest do
   alias Cadet.AIComments
   alias Cadet.AIComments.AIComment
   alias Cadet.Courses.Course
-  alias Cadet.{Repo}
+  alias Cadet.Repo
 
   setup do
     course_with_llm =