Skip to content

Commit c3ad8ba

Browse files
authored
fix: Wrong effective ID in unpublish notifications (#1196)
1 parent b840054 commit c3ad8ba

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

lib/cadet/assessments/assessments.ex

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1250,9 +1250,17 @@ defmodule Cadet.Assessments do
12501250
|> Submission.changeset(%{is_grading_published: false})
12511251
|> Repo.update()
12521252

1253+
# assumption: if team assessment, all team members are under the same avenger
1254+
effective_student_id =
1255+
if is_nil(submission.student_id) do
1256+
Teams.get_first_member(submission.team_id).student_id
1257+
else
1258+
submission.student_id
1259+
end
1260+
12531261
Notifications.handle_unpublish_grades_notifications(
12541262
submission.assessment.id,
1255-
Repo.get(CourseRegistration, submission.student_id)
1263+
Repo.get(CourseRegistration, effective_student_id)
12561264
)
12571265

12581266
{:ok, nil}

0 commit comments

Comments
 (0)