Skip to content

Commit c75224f

Browse files
committed
Fix format
1 parent a4b6df6 commit c75224f

File tree

3 files changed

+98
-67
lines changed

3 files changed

+98
-67
lines changed

test/cadet/assessments/assessments_test.exs

Lines changed: 57 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -3372,18 +3372,20 @@ defmodule Cadet.AssessmentsTest do
33723372
test "correctly fetches voting assessment id when contest exists" do
33733373
course = insert(:course)
33743374
config = insert(:assessment_config)
3375-
3375+
33763376
contest_assessment = insert(:assessment, %{course: course, config: config})
33773377
voting_assessment = insert(:assessment, %{course: course, config: config})
3378-
3378+
33793379
contest_question = insert(:programming_question, assessment: contest_assessment)
3380-
voting_question = insert(:voting_question, %{
3381-
assessment: voting_assessment,
3382-
question: build(:voting_question_content, contest_number: contest_assessment.number)
3383-
})
3384-
3380+
3381+
voting_question =
3382+
insert(:voting_question, %{
3383+
assessment: voting_assessment,
3384+
question: build(:voting_question_content, contest_number: contest_assessment.number)
3385+
})
3386+
33853387
result = Assessments.fetch_contest_voting_assesment_id(voting_assessment.id)
3386-
3388+
33873389
assert result == contest_assessment.id
33883390
end
33893391

@@ -3396,16 +3398,16 @@ defmodule Cadet.AssessmentsTest do
33963398
test "returns nil when no contest number matches" do
33973399
course = insert(:course)
33983400
config = insert(:assessment_config)
3399-
3401+
34003402
voting_assessment = insert(:assessment, %{course: course, config: config})
3401-
3403+
34023404
insert(:voting_question, %{
34033405
assessment: voting_assessment,
34043406
question: build(:voting_question_content, contest_number: "non_existent_number")
34053407
})
3406-
3408+
34073409
result = Assessments.fetch_contest_voting_assesment_id(voting_assessment.id)
3408-
3410+
34093411
assert is_nil(result)
34103412
end
34113413
end
@@ -3414,36 +3416,44 @@ defmodule Cadet.AssessmentsTest do
34143416
test "fetches all contests for a course" do
34153417
course = insert(:course)
34163418
config = insert(:assessment_config, %{type: "Contests"})
3417-
3418-
contest_assessment_1 = insert(:assessment, %{
3419-
course: course,
3420-
config: config,
3421-
is_published: true,
3422-
title: "Contest 1"
3423-
})
3424-
contest_assessment_2 = insert(:assessment, %{
3425-
course: course,
3426-
config: config,
3427-
is_published: false,
3428-
title: "Contest 2"
3429-
})
3430-
3419+
3420+
contest_assessment_1 =
3421+
insert(:assessment, %{
3422+
course: course,
3423+
config: config,
3424+
is_published: true,
3425+
title: "Contest 1"
3426+
})
3427+
3428+
contest_assessment_2 =
3429+
insert(:assessment, %{
3430+
course: course,
3431+
config: config,
3432+
is_published: false,
3433+
title: "Contest 2"
3434+
})
3435+
34313436
voting_assessment = insert(:assessment, %{course: course})
3432-
3437+
34333438
insert(:voting_question, %{
34343439
assessment: voting_assessment,
34353440
question: build(:voting_question_content, contest_number: contest_assessment_1.number)
34363441
})
3442+
34373443
insert(:voting_question, %{
34383444
assessment: voting_assessment,
34393445
question: build(:voting_question_content, contest_number: contest_assessment_2.number)
34403446
})
3441-
3447+
34423448
result = Assessments.fetch_all_contests(course.id)
3443-
3449+
34443450
assert length(result) == 2
3445-
assert Enum.find(result, fn c -> c.contest_id == contest_assessment_1.id end).published == true
3446-
assert Enum.find(result, fn c -> c.contest_id == contest_assessment_2.id end).published == false
3451+
3452+
assert Enum.find(result, fn c -> c.contest_id == contest_assessment_1.id end).published ==
3453+
true
3454+
3455+
assert Enum.find(result, fn c -> c.contest_id == contest_assessment_2.id end).published ==
3456+
false
34473457
end
34483458

34493459
test "returns empty list when no voting questions exist" do
@@ -3455,22 +3465,23 @@ defmodule Cadet.AssessmentsTest do
34553465
test "excludes contests that are not of type Contests" do
34563466
course = insert(:course)
34573467
non_contest_config = insert(:assessment_config, %{type: "Mission"})
3458-
3459-
non_contest_assessment = insert(:assessment, %{
3460-
course: course,
3461-
config: non_contest_config,
3462-
is_published: true
3463-
})
3464-
3468+
3469+
non_contest_assessment =
3470+
insert(:assessment, %{
3471+
course: course,
3472+
config: non_contest_config,
3473+
is_published: true
3474+
})
3475+
34653476
voting_assessment = insert(:assessment, %{course: course})
3466-
3477+
34673478
insert(:voting_question, %{
34683479
assessment: voting_assessment,
34693480
question: build(:voting_question_content, contest_number: non_contest_assessment.number)
34703481
})
3471-
3482+
34723483
result = Assessments.fetch_all_contests(course.id)
3473-
3484+
34743485
assert result == []
34753486
end
34763487
end
@@ -3515,7 +3526,7 @@ defmodule Cadet.AssessmentsTest do
35153526
)
35163527

35173528
top_2 = Assessments.fetch_top_relative_score_answers(contest_question.id, 2)
3518-
3529+
35193530
assert length(top_2) == 2
35203531
assert Enum.all?(top_2, fn ans -> ans.rank <= 2 end)
35213532
assert Enum.map(top_2, fn ans -> ans.relative_score end) == [10.0, 9.0]
@@ -3551,12 +3562,14 @@ defmodule Cadet.AssessmentsTest do
35513562
question: contest_question,
35523563
relative_score: 10.0
35533564
})
3565+
35543566
insert(:answer, %{
35553567
answer: build(:programming_answer),
35563568
submission: Enum.at(submission_list, 1),
35573569
question: contest_question,
35583570
relative_score: 10.0
35593571
})
3572+
35603573
insert(:answer, %{
35613574
answer: build(:programming_answer),
35623575
submission: Enum.at(submission_list, 2),
@@ -3565,7 +3578,7 @@ defmodule Cadet.AssessmentsTest do
35653578
})
35663579

35673580
top_2 = Assessments.fetch_top_relative_score_answers(contest_question.id, 2)
3568-
3581+
35693582
assert length(top_2) == 2
35703583
assert Enum.count(top_2, fn ans -> ans.rank == 1 end) == 2
35713584
end
@@ -3610,7 +3623,7 @@ defmodule Cadet.AssessmentsTest do
36103623
)
36113624

36123625
top_3 = Assessments.fetch_top_popular_score_answers(contest_question.id, 3)
3613-
3626+
36143627
assert length(top_3) == 3
36153628
assert Enum.all?(top_3, fn ans -> ans.rank <= 3 end)
36163629
assert Enum.map(top_3, fn ans -> ans.popular_score end) == [20.0, 19.0, 18.0]

test/cadet_web/admin_controllers/admin_assessments_controller_test.exs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ defmodule CadetWeb.AdminAssessmentsControllerTest do
165165
test_cr = conn.assigns.test_cr
166166
course = test_cr.course
167167
config = insert(:assessment_config, %{course: course})
168-
168+
169169
contest_assessment = insert(:assessment, %{course: course, config: config})
170170
contest_students = insert_list(5, :course_registration, %{course: course, role: :student})
171171
contest_question = insert(:programming_question, %{assessment: contest_assessment})
@@ -185,11 +185,12 @@ defmodule CadetWeb.AdminAssessmentsControllerTest do
185185
)
186186

187187
voting_assessment = insert(:assessment, %{course: course, config: config})
188-
189-
voting_question = insert(:voting_question, %{
190-
assessment: voting_assessment,
191-
question: build(:voting_question_content, contest_number: contest_assessment.number)
192-
})
188+
189+
voting_question =
190+
insert(:voting_question, %{
191+
assessment: voting_assessment,
192+
question: build(:voting_question_content, contest_number: contest_assessment.number)
193+
})
193194

194195
conn
195196
|> post(
@@ -205,7 +206,7 @@ defmodule CadetWeb.AdminAssessmentsControllerTest do
205206
test_cr = conn.assigns.test_cr
206207
course = test_cr.course
207208
config = insert(:assessment_config, %{course: course})
208-
209+
209210
contest_assessment = insert(:assessment, %{course: course, config: config})
210211
contest_students = insert_list(5, :course_registration, %{course: course, role: :student})
211212
contest_question = insert(:programming_question, %{assessment: contest_assessment})

test/cadet_web/controllers/assessments_controller_test.exs

Lines changed: 33 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1974,7 +1974,10 @@ defmodule CadetWeb.AssessmentsControllerTest do
19741974
@tag authenticate: :student
19751975
test "pagination with offset and limit", %{conn: conn} do
19761976
user = conn.assigns[:current_user]
1977-
test_cr = insert(:course_registration, %{course: insert(:course), role: :student, user: user})
1977+
1978+
test_cr =
1979+
insert(:course_registration, %{course: insert(:course), role: :student, user: user})
1980+
19781981
conn = assign(conn, :test_cr, test_cr)
19791982
course = test_cr.course
19801983
config = insert(:assessment_config, %{course: course})
@@ -2025,29 +2028,37 @@ defmodule CadetWeb.AssessmentsControllerTest do
20252028
@tag authenticate: :student
20262029
test "retrieves all contests for a course", %{conn: conn} do
20272030
user = conn.assigns[:current_user]
2028-
test_cr = insert(:course_registration, %{course: insert(:course), role: :student, user: user})
2031+
2032+
test_cr =
2033+
insert(:course_registration, %{course: insert(:course), role: :student, user: user})
2034+
20292035
conn = assign(conn, :test_cr, test_cr)
20302036
course = test_cr.course
20312037
config = insert(:assessment_config, %{type: "Contests", course: course})
20322038

2033-
contest_1 = insert(:assessment, %{
2034-
course: course,
2035-
config: config,
2036-
is_published: true,
2037-
title: "Contest 1"
2038-
})
2039-
contest_2 = insert(:assessment, %{
2040-
course: course,
2041-
config: config,
2042-
is_published: false,
2043-
title: "Contest 2"
2044-
})
2039+
contest_1 =
2040+
insert(:assessment, %{
2041+
course: course,
2042+
config: config,
2043+
is_published: true,
2044+
title: "Contest 1"
2045+
})
2046+
2047+
contest_2 =
2048+
insert(:assessment, %{
2049+
course: course,
2050+
config: config,
2051+
is_published: false,
2052+
title: "Contest 2"
2053+
})
20452054

20462055
voting_assessment = insert(:assessment, %{course: course})
2056+
20472057
insert(:voting_question, %{
20482058
assessment: voting_assessment,
20492059
question: build(:voting_question_content, contest_number: contest_1.number)
20502060
})
2061+
20512062
insert(:voting_question, %{
20522063
assessment: voting_assessment,
20532064
question: build(:voting_question_content, contest_number: contest_2.number)
@@ -2066,7 +2077,10 @@ defmodule CadetWeb.AssessmentsControllerTest do
20662077
@tag authenticate: :student
20672078
test "returns empty list when no contests exist", %{conn: conn} do
20682079
user = conn.assigns[:current_user]
2069-
test_cr = insert(:course_registration, %{course: insert(:course), role: :student, user: user})
2080+
2081+
test_cr =
2082+
insert(:course_registration, %{course: insert(:course), role: :student, user: user})
2083+
20702084
conn = assign(conn, :test_cr, test_cr)
20712085
course = test_cr.course
20722086

@@ -2083,7 +2097,10 @@ defmodule CadetWeb.AssessmentsControllerTest do
20832097
@tag authenticate: :student
20842098
test "uses visible_entries parameter when provided", %{conn: conn} do
20852099
user = conn.assigns[:current_user]
2086-
test_cr = insert(:course_registration, %{course: insert(:course), role: :student, user: user})
2100+
2101+
test_cr =
2102+
insert(:course_registration, %{course: insert(:course), role: :student, user: user})
2103+
20872104
conn = assign(conn, :test_cr, test_cr)
20882105
course = test_cr.course
20892106

0 commit comments

Comments
 (0)