Add more extensive tests

Author: RichDom2185

test/cadet/jobs/autograder/utilities_test.exs

@@ -72,18 +72,54 @@ defmodule Cadet.Autograder.UtilitiesTest do
     setup do
       course = insert(:course)
       config = insert(:assessment_config, %{course: course})
-      assessment = insert(:assessment, %{is_published: true, course: course, config: config})
+
+      # Individual assessment
+      assessment =
+        insert(:assessment, %{
+          is_published: true,
+          course: course,
+          config: config,
+          max_team_size: 1
+        })
+
       students = insert_list(5, :course_registration, %{role: :student, course: course})
       insert(:course_registration, %{course: build(:course), role: :student})
-      %{students: students, assessment: assessment}
+
+      # Team assessment
+      team_assessment =
+        insert(:assessment, %{
+          is_published: true,
+          course: course,
+          config: config,
+          max_team_size: 2
+        })
+
+      team_member1 = insert(:team_member, %{student: Enum.at(students, 0)})
+      team_member2 = insert(:team_member, %{student: Enum.at(students, 1)})
+
+      team1 =
+        insert(:team, %{assessment: team_assessment, team_members: [team_member1, team_member2]})
+
+      team_member3 = insert(:team_member, %{student: Enum.at(students, 2)})
+      team_member4 = insert(:team_member, %{student: Enum.at(students, 3)})
+
+      team2 =
+        insert(:team, %{assessment: team_assessment, team_members: [team_member3, team_member4]})
+
+      %{
+        individual: %{students: students, assessment: assessment},
+        team: %{teams: [team1, team2], assessment: team_assessment, teamless: [Enum.at(students, 4)]}
+      }
     end
 
-    test "it returns list of students with matching submissions", %{
-      students: students,
-      assessment: assessment
+    test "it returns list of students with matching submissions for individual assessments", %{
+      individual: %{students: students, assessment: assessment}
     } do
       submissions =
-        Enum.map(students, &insert(:submission, %{assessment: assessment, student: &1}))
+        Enum.map(
+          students,
+          &insert(:submission, %{assessment: assessment, student: &1, team: nil})
+        )
 
       expected = Enum.map(submissions, &%{student_id: &1.student_id, submission_id: &1.id})
 
@@ -95,9 +131,8 @@ defmodule Cadet.Autograder.UtilitiesTest do
       assert results == expected
     end
 
-    test "it returns list of students with without matching submissions", %{
-      students: students,
-      assessment: assessment
+    test "it returns list of students without matching submissions for individual assessments", %{
+      individual: %{students: students, assessment: assessment}
     } do
       expected_student_ids = Enum.map(students, & &1.id)
 
@@ -108,6 +143,29 @@ defmodule Cadet.Autograder.UtilitiesTest do
 
       assert results |> Enum.map(& &1.submission) |> Enum.uniq() == [nil]
     end
+
+    test "it returns list of students both with and without matching submissions for team assessments", %{
+      team: %{teams: teams, assessment: assessment, teamless: teamless}
+    } do
+      submissions =
+        Enum.map(teams, &%{
+          team_id: &1.id,
+          submission: insert(:submission, %{assessment: assessment, team: &1, student: nil})
+        })
+
+      expected = Enum.flat_map(teams, & &1.team_members) |> Enum.map(&%{
+        student_id: &1.student_id,
+        submission_id: Enum.find(submissions, fn s -> s.team_id == &1.team_id end).submission.id
+      })
+      expected = expected ++ Enum.map(teamless, &%{student_id: &1.id, submission_id: nil})
+
+      results =
+        assessment.id
+        |> Utilities.fetch_submissions(assessment.course_id)
+        |> Enum.map(&%{student_id: &1.student_id, submission_id: (if &1.submission, do: &1.submission.id, else: nil)})
+
+      assert results == expected
+    end
   end
 
   defp get_assessments_ids(assessments) do