refactor: Negate if condition

Author: RichDom2185

lib/cadet/jobs/autograder/grading_job.ex

@@ -103,17 +103,8 @@ defmodule Cadet.Autograder.GradingJob do
   end
 
   defp insert_empty_submission(%{student_id: student_id, assessment: assessment}) do
-    if !Assessments.is_team_assessment?(assessment.id) do
-      # Individual assessment
-      %Submission{}
-      |> Submission.changeset(%{
-        student_id: student_id,
-        assessment: assessment,
-        status: :submitted
-      })
-      |> Repo.insert!()
-    else
-      # Team assessment, get current team if any
+    if Assessments.is_team_assessment?(assessment.id) do
+      # Get current team if any
       team =
         Team
         |> where(assessment_id: ^assessment.id)
@@ -146,6 +137,15 @@ defmodule Cadet.Autograder.GradingJob do
         status: :submitted
       })
       |> Repo.insert!()
+    else
+      # Individual assessment
+      %Submission{}
+      |> Submission.changeset(%{
+        student_id: student_id,
+        assessment: assessment,
+        status: :submitted
+      })
+      |> Repo.insert!()
     end
   end