Skip to content

Commit e33b6c0

Browse files
authored
Fix: Fix limit function for grading table fetch function (#1190)
* fix: Fix limit functionality not working * feat: Implement test for pagination
1 parent b02b43c commit e33b6c0

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

lib/cadet/assessments/assessments.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1985,7 +1985,7 @@ defmodule Cadet.Assessments do
19851985
where: s.assessment_id in subquery(build_assessment_config_filter(params)),
19861986
where: ^build_submission_filter(params),
19871987
where: ^build_course_registration_filter(params, grader),
1988-
limit: ^params[:limit],
1988+
limit: ^params[:page_size],
19891989
offset: ^params[:offset],
19901990
select: %{
19911991
id: s.id,

test/cadet/assessments/assessments_test.exs

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2210,6 +2210,29 @@ defmodule Cadet.AssessmentsTest do
22102210
Map.put(seed, :total_submissions, total_submissions)
22112211
end
22122212

2213+
test "limit submissions", %{
2214+
course_regs: %{avenger1_cr: avenger}
2215+
} do
2216+
{_, res} =
2217+
Assessments.submissions_by_grader_for_index(avenger, %{
2218+
:page_size => 1
2219+
})
2220+
2221+
assert length(res[:data][:submissions]) == 1
2222+
end
2223+
2224+
test "limit submisssions 2", %{
2225+
course_regs: %{avenger1_cr: avenger},
2226+
assessments: assessments
2227+
} do
2228+
{_, res} =
2229+
Assessments.submissions_by_grader_for_index(avenger, %{
2230+
:page_size => 2
2231+
})
2232+
2233+
assert length(res[:data][:submissions]) == 2
2234+
end
2235+
22132236
test "filter by assessment title", %{
22142237
course_regs: %{avenger1_cr: avenger},
22152238
assessments: assessments,

0 commit comments

Comments
 (0)