Hide long summary unless unattempted (#264)

* Add attempted prop for AssessmentWorkspace

* Pass attempted field to AssessmentWorkspace

* Change to notAttempted property

There are fields such as attemping and attempted that will cause
confusion

* Remove attmpted field from IAssessmentOverview

It is redundant

* Pass in proper field to AssessmentWorkspace

There was a bug there, whoops

Author: remo5000

src/components/assessment/AssessmentWorkspace.tsx

@@ -37,6 +37,7 @@ export type StateProps = {
 export type OwnProps = {
   assessmentId: number
   questionId: number
+  notAttempted: boolean
   closeDate: string
 }
 
@@ -65,7 +66,12 @@ class AssessmentWorkspace extends React.Component<
   AssessmentWorkspaceProps,
   { showOverlay: boolean }
 > {
-  public state = { showOverlay: false }
+  public constructor(props: AssessmentWorkspaceProps) {
+    super(props)
+    this.state = {
+      showOverlay: false
+    }
+  }
 
   /**
    * After mounting (either an older copy of the assessment
@@ -74,7 +80,7 @@ class AssessmentWorkspace extends React.Component<
    */
   public componentDidMount() {
     this.props.handleAssessmentFetch(this.props.assessmentId)
-    if (this.props.questionId === 0) {
+    if (this.props.questionId === 0 && this.props.notAttempted) {
       this.setState({ showOverlay: true })
     }
   }

src/components/assessment/__tests__/AssessmentWorkspace.tsx

@@ -8,6 +8,7 @@ import AssessmentWorkspace, { AssessmentWorkspaceProps } from '../AssessmentWork
 const defaultProps: AssessmentWorkspaceProps = {
   activeTab: 0,
   assessmentId: 0,
+  notAttempted: true,
   closeDate: '2048-06-18T05:24:26.026Z',
   editorValue: null,
   editorWidth: '50%',

src/components/assessment/assessmentShape.ts

@@ -2,7 +2,6 @@
  * Used to display information regarding an assessment in the UI.
  */
 export interface IAssessmentOverview {
-  attempted: boolean
   category: AssessmentCategory
   closeAt: string
   coverImage: string

src/components/assessment/index.tsx

@@ -87,11 +87,12 @@ class Assessment extends React.Component<IAssessmentProps, State> {
     // If there is an assessment to render, create a workspace. The assessment
     // overviews must still be loaded for this, to send the due date.
     if (assessmentId !== null && this.props.assessmentOverviews !== undefined) {
+      const overview = this.props.assessmentOverviews.filter(a => a.id === assessmentId)[0]
       const assessmentProps: AssessmentProps = {
         assessmentId,
         questionId,
-        // get the closeDate of the assessment
-        closeDate: this.props.assessmentOverviews.filter(a => a.id === assessmentId)[0].closeAt
+        notAttempted: overview.status === AssessmentStatuses.not_attempted,
+        closeDate: overview.closeAt
       }
       return <AssessmentWorkspaceContainer {...assessmentProps} />
     }

src/mocks/assessmentAPI.ts

@@ -12,7 +12,6 @@ import { externalLibraries } from '../reducers/externalLibraries'
 
 const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
   {
-    attempted: true,
     category: AssessmentCategories.Mission,
     closeAt: '2048-06-18T05:24:26.026Z',
     coverImage: 'https://fakeimg.pl/300/',
@@ -26,7 +25,6 @@ const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
     story: 'mission-1'
   },
   {
-    attempted: false,
     category: AssessmentCategories.Mission,
     closeAt: '2048-06-18T05:24:26.026Z',
     coverImage: 'https://fakeimg.pl/350x200/?text=World&font=lobster',
@@ -40,7 +38,6 @@ const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
     story: 'mission-2'
   },
   {
-    attempted: true,
     category: AssessmentCategories.Sidequest,
     closeAt: '2048-06-18T05:24:26.026Z',
     coverImage: 'https://fakeimg.pl/350x200/?text=Hello',
@@ -57,7 +54,6 @@ const mockOpenAssessmentsOverviews: IAssessmentOverview[] = [
 
 const mockClosedAssessmentOverviews: IAssessmentOverview[] = [
   {
-    attempted: true,
     category: AssessmentCategories.Mission,
     closeAt: '2008-06-18T05:24:26.026Z',
     coverImage: 'https://fakeimg.pl/350x200/ff0000/000',
@@ -71,7 +67,6 @@ const mockClosedAssessmentOverviews: IAssessmentOverview[] = [
     story: 'mission-3'
   },
   {
-    attempted: false,
     category: AssessmentCategories.Sidequest,
     closeAt: '2008-06-18T05:24:26.026Z',
     coverImage: 'https://fakeimg.pl/350x200/ff0000,128/000,255',